Projects tigase _server server-core Issues #411
Development Guide proposes to use deprecated code (#411)
Gabriel Rossetti opened 10 years ago
Due Date
2015-05-21

Hi all,

if you look here: [[http://docs.tigase.org/tigase-server/snapshot/Development_Guide/webhelp/_global_configuration_settings.html]] is says to use SHARED_USER_REPO_PROP_KEY@, @SHARED_USER_REPO_POOL_PROP_KEY & SHARED_AUTH_REPO_PROP_KEY which are marked as deprecated. The page needs to be updated to use @RepositoryFactory@.

Is this (e.g. AuthRepository auth_repo = (AuthRepository) properties.get(RepositoryFactory.SHARED_AUTH_REPO_PROP_KEY)@) still the way to get the auth & user repos or should @RepositoryFactory.getAuthRepository() & RepositoryFactory.getUserRepository() be used now? Pls update the example if this is is the way to do this now.

Also you reference UserAuthRepository which I was unable to find in 5.2.1, not sure if this is an error or if it is in the development version.

Thx,

Gabriel

Artur Hefczyc commented 10 years ago

Wojciech, please provide an answer and update documentation (or code) if necessary.

wojciech.kapcia@tigase.net commented 10 years ago

Gabriel Rossetti wrote:

if you look here: [[http://docs.tigase.org/tigase-server/snapshot/Development_Guide/webhelp/_global_configuration_settings.html]] is says to use SHARED_USER_REPO_PROP_KEY@, @SHARED_USER_REPO_POOL_PROP_KEY & SHARED_AUTH_REPO_PROP_KEY which are marked as deprecated. The page needs to be updated to use @RepositoryFactory@.

Thank you, corrected in the repository.

Is this (e.g. AuthRepository auth_repo = (AuthRepository) properties.get(RepositoryFactory.SHARED_AUTH_REPO_PROP_KEY)@) still the way to get the auth & user repos or should @RepositoryFactory.getAuthRepository() & RepositoryFactory.getUserRepository() be used now? Pls update the example if this is is the way to do this now.

Method described in the docs refer to configuration and obtaining default, shared repository(pool) instance. @RepositoryFactory.get*()* methods on the other hand can provide you your own pool of repositories.

Also you reference UserAuthRepository which I was unable to find in 5.2.1, not sure if this is an error or if it is in the development version.

This was remnant from older code, corrected.

Gabriel Rossetti commented 10 years ago

Wojciech Kapcia wrote:

Gabriel Rossetti wrote:

Thanks for the corrections you did.

Is this (e.g. AuthRepository auth_repo = (AuthRepository) properties.get(RepositoryFactory.SHARED_AUTH_REPO_PROP_KEY)@) still the way to get the auth & user repos or should @RepositoryFactory.getAuthRepository() & RepositoryFactory.getUserRepository() be used now? Pls update the example if this is is the way to do this now.

Method described in the docs refer to configuration and obtaining default, shared repository(pool) instance. @RepositoryFactory.get*()* methods on the other hand can provide you your own pool of repositories.

Ok, I see. Maybe this can be mentioned somewhere?

Also, I cannot close the issue myself so since it is asigned to me I get email reminders all the time for this issue, once you have answered the above can you pls close it?

Thanks,

Gabriel

wojciech.kapcia@tigase.net commented 10 years ago

I'll update the documentation later on.

wojciech.kapcia@tigase.net commented 9 years ago

Applied in changeset commit:tigase-server|223dbee3.

issue 1 of 1
Type
Bug
Priority
Normal
Assignee
RedmineID
2603
Spent time
18h
Issue Votes (0)
Watchers (0)
Reference
tigase/_server/server-core#411
Please wait...
Page is in error, reload to recover