Projects tigase _server server-core Issues #349
MsgRepositoryImpl not overridable (#349)
Robert Larsen opened 1 decade ago
Due Date
2014-08-21

I have implemented my own user repository class and it works fine.

But Tigase encounters problems related to offline messages.

Apparently MsgRepositoryImpl does its own JID to user id lookup instead of using the function that the user repository class has already implemented.

Also, even thou there is a MsgRepositoryIfc interface there is no way of providing your own since Tigase explicitly uses MsgRepositoryImpl.

Robert Larsen commented 1 decade ago

MessageAmp class instantiates another version of the MsgRepositoryIfc (MsgRepository) which is also not overridable.

Andrzej Wójcik (Tigase) commented 1 decade ago

I added ability to use custom implementation of MsgRepositoryIfc for OfflineMessages. New class should implement OfflineMsgRepositoryIfc to be able to use this class as MsgRepositoryIfc implementation for OfflineMessages processor. Name of class to use needs to be passed as msg-repo-class parameter of OfflineMessages processor.

To use custom implementation of MsgRepositoryIfc for MessageAmp processor and Store action of AMP component you need to implement MsgRepositoryIfc and pass name of class as value of --amp-repo-class property from etc/init.properties file.

By default Tigase XMPP Server currently uses MessageAmp plugin and AMP component to handle processing of offline messages, so only custom implementation of MsgRepositoryIfc for MessageAmp processor may be needed.

Robert Larsen commented 1 decade ago

Looks fine, but I cannot test the development branch.

It complains about me building with Java 1.6 as a target. If I change 'ant-definitions.xml' to have source="1.7" and target="1.7" the build fails with with lots of unknown classes or no suitable methods found. I have the following in the 'jars' folder:

$ ls jars/

derby.jar derbytools.jar groovy-all.jar mysql-connector-java.jar postgresql.jar tigase-utils-3.4.4-SNAPSHOT.jar tigase-xmltools-3.4.5-SNAPSHOT.jar

Robert Larsen commented 1 decade ago

If this one is resolved, why do I keep getting "You have issues with due dates" mails about it?

wojciech.kapcia@tigase.net commented 1 decade ago

Robert Larsen wrote:

Looks fine, but I cannot test the development branch.

It complains about me building with Java 1.6 as a target. If I change 'ant-definitions.xml' to have source="1.7" and target="1.7" the build fails with with lots of unknown classes or no suitable methods found. I have the following in the 'jars' folder:

A while back we switched to jdk7 as a minimum version required for Tigase. We also use maven to build all projects - ant scripts haven't been updated for a while now so I would recommend switching to maven.

If this one is resolved, why do I keep getting "You have issues with due dates" mails about it?

You will keep getting them until issue is closed. Issue was resolved and assigned to you to verify and make final decision whether to get more information of close it as being done.

Robert Larsen commented 1 decade ago

Alright, I got it working with Maven a while ago and has been using this in my tests. It works perfectly (thanks for that), so you can close this issue. I don't think I can close it.

issue 1 of 1
Type
New Feature
Priority
Normal
Assignee
RedmineID
2067
Version
tigase-server-7.0.0
Spent time
9h
Issue Votes (0)
Watchers (0)
Reference
tigase/_server/server-core#349
Please wait...
Page is in error, reload to recover