message carbons plugin makes messages not deliverable to their destinators any longer (#286)

Activities

kellogs . opened 1 decade ago

The lines from MessageCarbons.java:

 @	private static final String[][] ELEMENTS = { { "message" }, { "iq", "enable" }, { "iq", "disable" } };

private static final String[] XMLNSS = { XMPPProcessor.CLIENT_XMLNS, XMLNS, XMLNS };@

are responsible for the branching below from SessionManager.processPacket(..) to be skipped, thus a regular message never being routed through the defPacketHandler:

 @   // postTm = System.currentTimeMillis() - startTime;

	if (!stop &&!packet.wasProcessed() && ((packet.getStanzaTo() == null) ||

			(!isLocalDomain(packet.getStanzaTo().toString())))) {

		if (defPacketHandler.canHandle(packet, conn)) {

			ProcessingThreads<ProcessorWorkerThread> pt = workerThreads.get(defHandlerProc

					.id());

			if (pt == null) {

				pt = workerThreads.get(defPluginsThreadsPool);

			}

			pt.addItem(defHandlerProc, packet, conn);

			packet.processedBy(defHandlerProc.id());

		}

	}@

        packet.wasProcessed() returns true in the test above due to MessageCarbons.java plugin processing the common <message xmlns="jabber:client" ... > stanzas.

Observed in commit object @48635d0 -"tigase-issue #5.2.0 release"

Andrzej Wójcik (Tigase) commented 1 decade ago

You are right and due to that we have enabled MessageAmp plugin by default which is responsible for forwarding message packets.

If I remember correctly now you need to use MessageAmp plugin or if you disabled MessageAmp plugin you should enable Message plugin which will be responsible for delivering message stanzas correctly.

Type	Bug
Priority	Normal
Assignee	Artur Hefczyc
RedmineID	1744
Version	tigase-server-5.2.0

Issue Votes (0)

Watchers (0)

Reference

tigase/_server/server-core#286