Issues with Comp and Plugin manager scripts (#241)

Wojciech Kapcia (Tigase) opened 1 decade ago

in cluster environment removing non-clustered components (amp, muc, etc) causes NPE:

2013-09-24 10:56:49.540 [in_0-message-router]  MessageRouter.setProperties()  WARNING:  exception releasing component:
java.lang.ClassCastException: tigase.muc.MUCComponent cannot be cast to tigase.cluster.api.ClusteredComponentIfc
	at tigase.cluster.ClusterController.componentRemoved(ClusterController.java:66)
	at tigase.server.AbstractComponentRegistrator.deleteComponent(AbstractComponentRegistrator.java:135)

NPE when adding component

NPE when adding component
java.lang.NullPointerException: Cannot invoke method keySet() on null object

after removing component it still shows on the list.

Activities

Andrzej Wójcik (Tigase) commented 1 decade ago

I fixed reported issues and few others I've found during testing of this script.
Wojciech Kapcia (Tigase) commented 1 decade ago
a few more things:

trying to edit basic-conf component throws exceptions:

javax.script.ScriptException: java.lang.Exception: Could not find component class for component: basic-conf javax.script.ScriptException: javax.script.ScriptException: java.lang.Exception: Could not find component class for component: basic-conf …

while removing component removes it from service discovery it is still present in the list of components to edit/remove (within the script)

--

I've created TTS tests for add/edit/remove but due to limitations of TTS they mostly check whether ad-hoc is at least functioning;
Andrzej Wójcik (Tigase) commented 1 decade ago

Fixed NPE and fixed removing from list of components to remove and to edit if component is removed

Wojciech Kapcia (Tigase) commented 1 decade ago

OK, CompManager is fixed.

Similar plugin to manage plugins doesn't work as well.

<iq type="set" to="basic-conf@atlantiscity" id="ad47a">
<command xmlns="http://jabber.org/protocol/commands" node="plugin-manager"/>
</iq>


<iq from="basic-conf@atlantiscity" type="result" to="admin@atlantiscity/Psi+" id="ad47a">
<command xmlns="http://jabber.org/protocol/commands" status="executing" node="plugin-manager">
<x xmlns="jabber:x:data" type="form">
<field type="hidden" var="submit">
<value>submit</value>
</field>
</x>
<actions execute="complete">
<complete/>
</actions>
</command>
</iq>

Andrzej Wójcik (Tigase) commented 1 decade ago

I modified this script to make it work outside of OSGi environment.
Wojciech Kapcia (Tigase) commented 1 decade ago

Plugins are now listed but the changes are not saved nor applied (i.e. either selecting or deselecting plugin doesn't enabled or disable it)
Andrzej Wójcik (Tigase) commented 1 decade ago

It was working fine until reload of plugins/processors was blocked by additional checking if component is initialized, which allowed reload in plugins only if component was not initialized yet. I changed implementation of plugins reload mechanism to make it work and I fixed root cause for which this condition was added.

Wojciech Kapcia (Tigase) commented 1 decade ago

following scenario:

disable plugin (e.g. jabber:iq:version)
try to re-enable it

doesn't work and throws Exception:

java.lang.StringIndexOutOfBoundsException: String index out of range: 0
	at java.lang.String.charAt(String.java:658)
	at tigase.server.xmppsession.SessionManagerConfig.getDefaults(SessionManagerConfig.java:227)
	…

Andrzej Wójcik (Tigase) commented 1 decade ago

Applied in changeset tigase-server|commit:9e8f49dd515df6615d75c8bac567194738597eca.
Login to comment

Type	Bug
Priority	Normal
Assignee	Wojciech Kapcia (Tigase)
RedmineID	1563
Version	tigase-server-5.2.0
Spent time	0

Issue Votes (0)

Watchers (0)

Reference

tigase/_server/server-core#241