|
Artur Hefczyc opened 1 decade ago
|
|
Circular dependency fixed. It was added by Eclipse formatted, because it found SaslAuth in… JavaDoc… I can't find tigase.xmpp.impl in tigase.auth.** |
|
|
Bartosz Malkowski wrote:
(line #9) This is the only file I looked, therefore I do not know anything about possible import in other files. |
|
|
Is it all fixed yet? If so please close the ticket. |
| Type |
Bug
|
| Priority |
Normal
|
| Assignee | |
| RedmineID |
1552
|
| Version |
tigase-server-5.2.0
|
Issue Votes (0)
Watchers (0)
This is not a code logic bug but rather a design bug.
The class tigase.auth.MechanismSelector imports tigase.xmpp.impl.SaslAuth which imports tigase.auth.MechanismSelector. I suppose this is easily fixed.
Another problem I find in the dependency is importing classes from tigase.xmpp.impl package in classes of tigase.auth package. The tigase.auth is considered as kind of auth library for the XMPP implementation and should not import anything from the application level packages.