Projects tigase _server server-core Issues #19
Privacy lists using only the first rule (#19)
wojciech.kapcia@tigase.net opened 1 decade ago

The problem is described on the development forum . And here is a copy of the user's post:

I have been having some troubles with Privacy Lists : Tigase 5.0 is behaving like when a privacy list is set on a user only the first rule is processed and the following are ignored.

With this small change in tigase.xmpp.impl.JabberiqPrivacy, Tigase behaves much better for me :

In JabberIqPrivacy.java line 401, replace

if ( !type_matched) {

break;

} // end of if (!type_matched)

with

if ( !type_matched) {

continue;

} // end of if (!type_matched)

When the first rule not matching with the processed packet is met, the break is currently exiting the for loop on privacy-list rules.

However subsequent rules should also be tried and matched against the packet.

Replacing break with continue will simply jump to processing the next rule in the list.

Would you agree with that change ?

Referenced from commit 1 year ago
fix issue: web browser complain bad message format if there are Chinese characters #18 (#19)
* fix: send chinese character   error ,because of wrong Content-Length

Signed-off-by: yinghao niu <bullflying@outlook.com>
towith committed with GitHub 5 years ago
issue 1 of 1
Type
Bug
Priority
Minor
Assignee
RedmineID
29
Estimation
7h 30m
Issue Votes (0)
Watchers (0)
Reference
tigase/_server/server-core#19
Please wait...
Page is in error, reload to recover