Projects tigase _server server-core Issues #167
equality comparison renders AMP useless (#167)
Closed
tom quas opened 1 decade ago

MessageAmp#process:

	if (packet.getElemName() == "presence") {

obviously, this should be

	if ("presence".equals(packet.getElemName()) {

messages won't get loaded/delivered once put in the repository

Artur Hefczyc commented 1 decade ago

For performance reasons and to reduce memory consumption Tigase's XML parser uses String.intern() processing for XML element names. Therefore it is legal and correct to use '==' for string comparison in the Tigase code, for XML element names testing.

What exact problems do you think it causes for you?

issue 1 of 1
Type
Bug
Priority
Blocker
Assignee
RedmineID
927
Version
tigase-server-5.1.3
Issue Votes (0)
Watchers (0)
Reference
tigase/_server/server-core#167
Please wait...
Page is in error, reload to recover