equality comparison renders AMP useless (#167)

tom quas opened 1 decade ago

MessageAmp#process:

	if (packet.getElemName() == "presence") {

obviously, this should be

	if ("presence".equals(packet.getElemName()) {

messages won't get loaded/delivered once put in the repository

Artur Hefczyc commented 1 decade ago

For performance reasons and to reduce memory consumption Tigase's XML parser uses String.intern() processing for XML element names. Therefore it is legal and correct to use '==' for string comparison in the Tigase code, for XML element names testing.

What exact problems do you think it causes for you?
Login to comment

Issue Votes (0)

Watchers (0)

Reference

tigase/_server/server-core#167