Some <stream:features> child elements are duplicated, breaking xmpp-rs interop (#1573)

Jonas Schäfer opened 2 weeks ago

Encountered this in the wild, when establishing a c2s-connection against xmpp:tigase.im:

<stream:features xmlns:stream="http://etherx.jabber.org/streams">
  <authentication xmlns="urn:xmpp:sasl:2">
    <mechanism>SCRAM-SHA-256-PLUS</mechanism>
    <mechanism>SCRAM-SHA-1-PLUS</mechanism>
    <mechanism>SCRAM-SHA-256</mechanism>
    <mechanism>SCRAM-SHA-1</mechanism>
    <mechanism>PLAIN</mechanism>
    <mechanism>ANONYMOUS</mechanism>
    <inline>
      <sm xmlns="urn:xmpp:sm:3"/>
      <bind xmlns="urn:xmpp:bind:0">
        <inline>
          <feature var="urn:xmpp:carbons:2"/>
          <feature var="urn:xmpp:sm:3"/>
        </inline>
      </bind>
    </inline>
  </authentication>
  <sasl-channel-binding xmlns="urn:xmpp:sasl-cb:0">
    <channel-binding type="tls-server-end-point"/>
  </sasl-channel-binding>
  <auth xmlns="http://jabber.org/features/iq-auth"/>
  <mechanisms xmlns="urn:ietf:params:xml:ns:xmpp-sasl">
    <mechanism>SCRAM-SHA-256-PLUS</mechanism>
    <mechanism>SCRAM-SHA-1-PLUS</mechanism>
    <mechanism>SCRAM-SHA-256</mechanism>
    <mechanism>SCRAM-SHA-1</mechanism>
    <mechanism>PLAIN</mechanism>
    <mechanism>ANONYMOUS</mechanism>
  </mechanisms>
  <sasl-channel-binding xmlns="urn:xmpp:sasl-cb:0">
    <channel-binding type="tls-server-end-point"/>
  </sasl-channel-binding>
  <compression xmlns="http://jabber.org/features/compress">
    <method>zlib</method>
  </compression>
</stream:features>

This breaks interoperability with xmpp-rs, since xmpp-rs chokes on the duplicate <sasl-channel-binding/> child inside <stream:features/>.

Activities

Andrzej Wójcik (Tigase) changed fields 2 weeks ago
Name Previous Value Current Value
Assignee

hantu85

andrzej.wojcik
Andrzej Wójcik (Tigase) changed fields 2 weeks ago
Name Previous Value Current Value
Version
empty
8.4.0
Andrzej Wójcik (Tigase) added to iteration "tigase-server-8.5.0" 2 weeks ago
Andrzej Wójcik (Tigase) changed state to 'In Progress' 2 weeks ago
Previous Value Current Value
Open

In Progress
Andrzej Wójcik (Tigase) commented 2 weeks ago

I've identified the cause of the issue and resolved it. The fix will be part of tomorrow's snapshot build.

As for duplicated IBR feature, I was unable to identify possible causes as I was unable to replicate the issue nor to find possible part of the code that could cause this issue for IBR.
Andrzej Wójcik (Tigase) changed state to 'In QA' 2 weeks ago
Previous Value Current Value
In Progress

In QA
Jonas Schäfer commented 2 weeks ago

@andrzej.wojcik Thanks for looking into it! In the meantime, I found that the server which duplicated the IBR element is in fact a Brosody instance.
Login to comment

Name	Previous Value	Current Value
Assignee	hantu85	andrzej.wojcik

Name	Previous Value	Current Value
Version	empty	8.4.0

Previous Value	Current Value
Open	In Progress

Previous Value	Current Value
In Progress	In QA

Type	Bug
Priority	Normal
Assignee	Andrzej Wójcik (Tigase)
Version	8.4.0
Sprints	n/a
Customer	n/a

Iterations

tigase-server-8.5.0 Open

Issue Votes (0)

Watchers (5)

Reference

tigase/_server/server-core#1573