Projects tigase _server server-core Issues #1564
SessMan and VHostMan not visible for non-admin users (#1564)
  • Andrzej Wójcik (Tigase) commented 2 weeks ago

    The issue here is more complex than just "invisibility" to non-admin users.

    By default those components should be invisible to non-admin users, but should appear as visible if there are commands with ACL that allow non-admin users to execute them.

    With following config:

    'vhost-man' {
        commands {
            'comp-repo-item-add' = 'LOCAL'
            'comp-repo-item-remove' = 'LOCAL'
            'comp-repo-item-update' = 'LOCAL'
            'query-dns' = 'LOCAL'
            'ssl-certificate-add' = 'LOCAL'
        }
    }
    

    vhost-man will be visible to non-admin users as listed commands will be executable by local users.

    With sess-man similar rules applied, however, I think that "credentials management" commands should be accessible to normal users. To resolve that, I've added an option to define default ACL for Java-based commands and set those values to LOCAL for "credentials management" commands - that made sess-man visible.

    Changes are part of the issue-1564 branch. @wojtek please review changes and modified behavior.

  • Andrzej Wójcik (Tigase) changed state to 'In QA' 2 weeks ago
    Previous Value Current Value
    Open
    In QA
  • Andrzej Wójcik (Tigase) changed fields 2 weeks ago
    Name Previous Value Current Value
    Assignee
    andrzej.wojcik
    wojtek
  • Wojciech Kapcia (Tigase) added "Related" #1194 2 weeks ago
  • Wojciech Kapcia (Tigase) added "Related" #1214 2 weeks ago
  • Wojciech Kapcia (Tigase) added "Related" DC-9 2 weeks ago
  • Wojciech Kapcia (Tigase) referenced from other issue 2 weeks ago
  • Wojciech Kapcia (Tigase) added "Related" #1570 2 weeks ago
  • Wojciech Kapcia (Tigase) commented 2 weeks ago

    Thank you. This look good and works well.

    I was pondering this issue a bit more and while getDefaultACL() is great first step, I think we will have to improve the ACL system in the future to handle "VHost owner should be able to manage the domain and users of it's domain". We do have DOMAIN_OWNER and DOMAIN_ADMIN ACLs but when doing the ad-hoc rewrite ( #tigase/_server/server-core#1194 ) we will have to ponder the correct defaults for certain ad-hocs and the logic checking (which is, in most cases) done in each ad-hoc individually which is highly inefficient… (rel.: #tigase/_server/server-core#1570 )

  • Wojciech Kapcia (Tigase) changed state to 'Closed' 2 weeks ago
    Previous Value Current Value
    In QA
    Closed
  • Andrzej Wójcik (Tigase) commented 4 days ago

    Reopening to fix found NPE issue

  • Andrzej Wójcik (Tigase) changed state to 'In Progress' 4 days ago
    Previous Value Current Value
    Closed
    In Progress
  • Andrzej Wójcik (Tigase) changed fields 4 days ago
    Name Previous Value Current Value
    Assignee
    wojtek
    andrzej.wojcik
  • Andrzej Wójcik (Tigase) added "Related" Customers/atom#378 4 days ago
  • Andrzej Wójcik (Tigase) commented 4 days ago

    I've resolved the issue with NPE.

  • Andrzej Wójcik (Tigase) changed state to 'In QA' 4 days ago
    Previous Value Current Value
    In Progress
    In QA
issue 1 of 1
Type
Bug
Priority
Normal
Assignee
Version
8.5.0
Sprints
n/a
Customer
n/a
Iterations
Issue Votes (0)
Watchers (3)
Reference
tigase/_server/server-core#1564
Please wait...
Page is in error, reload to recover