Improve JDK version checking for dependencies when jar is multi-release (#1533)

Wojciech Kapcia (Tigase) opened 1 year ago

BouncyCastle use multi-release feature of jar packing various variants/versions:

$ ls -lah bc/META-INF/versions/
total 0
drwxr-xr-x 6 wojtek staff 192 Apr 18 04:19 .
drwxr-xr-x 7 wojtek staff 224 Jun  7 18:35 ..
drwxr-xr-x 4 wojtek staff 128 Apr 18 04:19 11
drwxr-xr-x 4 wojtek staff 128 Apr 18 04:19 15
drwxr-xr-x 4 wojtek staff 128 Apr 18 04:19 21
drwxr-xr-x 5 wojtek staff 160 Apr 18 04:19 9

Which results in our checker complaining about version mismatch:

xmpp-1  | [2024-06-07 16:28:15:418] [WARNING ] [                  main ] ClassUtil.getClassesFromNames()  : Class: META-INF.versions.21.org.bouncycastle.pqc.jcajce.provider.NTRU compiled using newer JDK version. Please upgrade your JDK!
xmpp-1  | [2024-06-07 16:28:15:419] [WARNING ] [                  main ] ClassUtil.getClassesFromNames()  : Class: META-INF.versions.21.org.bouncycastle.pqc.jcajce.provider.NTRU$Mappings compiled using newer JDK version. Please upgrade your JDK!
xmpp-1  | [2024-06-07 16:28:15:422] [WARNING ] [                  main ] ClassUtil.getClassesFromNames()  : Class: META-INF.versions.21.org.bouncycastle.pqc.jcajce.provider.NTRUPrime compiled using newer JDK version. Please upgrade your JDK!
xmpp-1  | [2024-06-07 16:28:15:423] [WARNING ] [                  main ] ClassUtil.getClassesFromNames()  : Class: META-INF.versions.21.org.bouncycastle.pqc.jcajce.provider.NTRUPrime$Mappings compiled using newer JDK version. Please upgrade your JDK!
xmpp-1  | [2024-06-07 16:28:15:423] [WARNING ] [                  main ] ClassUtil.getClassesFromNames()  : Class: META-INF.versions.21.org.bouncycastle.pqc.jcajce.provider.Util compiled using newer JDK version. Please upgrade your JDK!
xmpp-1  | [2024-06-07 16:28:15:424] [WARNING ] [                  main ] ClassUtil.getClassesFromNames()  : Class: META-INF.versions.21.org.bouncycastle.pqc.jcajce.provider.ntru.NTRUDecapsulatorSpi compiled using newer JDK version. Please upgrade your JDK!
xmpp-1  | [2024-06-07 16:28:15:424] [WARNING ] [                  main ] ClassUtil.getClassesFromNames()  : Class: META-INF.versions.21.org.bouncycastle.pqc.jcajce.provider.ntru.NTRUEncapsulatorSpi compiled using newer JDK version. Please upgrade your JDK!
xmpp-1  | [2024-06-07 16:28:15:425] [WARNING ] [                  main ] ClassUtil.getClassesFromNames()  : Class: META-INF.versions.21.org.bouncycastle.pqc.jcajce.provider.ntru.NTRUKEMSpi compiled using newer JDK version. Please upgrade your JDK!
xmpp-1  | [2024-06-07 16:28:15:425] [WARNING ] [                  main ] ClassUtil.getClassesFromNames()  : Class: META-INF.versions.21.org.bouncycastle.pqc.jcajce.provider.ntruprime.SNTRUPrimeDecapsulatorSpi compiled using newer JDK version. Please upgrade your JDK!
xmpp-1  | [2024-06-07 16:28:15:426] [WARNING ] [                  main ] ClassUtil.getClassesFromNames()  : Class: META-INF.versions.21.org.bouncycastle.pqc.jcajce.provider.ntruprime.SNTRUPrimeEncapsulatorSpi compiled using newer JDK version. Please upgrade your JDK!
xmpp-1  | [2024-06-07 16:28:15:426] [WARNING ] [                  main ] ClassUtil.getClassesFromNames()  : Class: META-INF.versions.21.org.bouncycastle.pqc.jcajce.provider.ntruprime.SNTRUPrimeKEMSpi compiled using newer JDK version. Please upgrade your JDK!

Activities

Wojciech Kapcia (Tigase) changed state to 'In Progress' 1 year ago
Previous Value Current Value
Open

In Progress
Wojciech Kapcia (Tigase) changed state to 'In QA' 1 year ago
Previous Value Current Value
In Progress

In QA
Wojciech Kapcia (Tigase) commented 1 year ago

Added check when trying to load incompatible Class version.
Login to comment

Previous Value	Current Value
Open	In Progress

Previous Value	Current Value
In Progress	In QA

Type	Improvement
Priority	Normal
Assignee	Andrzej Wójcik (Tigase)
Version	none
Sprints	n/a
Customer	n/a

Iterations

tigase-server-8.5.0 Open

Issue Votes (0)

Watchers (3)

Reference

tigase/_server/server-core#1533