Retrying undelivered packets should only happen for payload packets in cluster (#1513)

Wojciech Kapcia (Tigase) opened 1 year ago

In case of writing packet to socket problem, packet may be slated for re-delivery, but this only should apply to proper cluster payload packets (IQ and message stanzas).


Context: there was a problem with connectivity, which resulted in NPE because tigase tried to re-deliver  `<handshake/>` packet, which should have been dropped. What's more, particular point may result in subsequent closing of the connection:

```
[2023-12-09 16:33:11:374] [SEVERE ] [in_10-cl-comp ] AbstractMessageReceiver$QueueListener.run(): Exception during packet processing: from-null, to=null, serverAuthorisedStanzaFrom-Optional. empty, DATA=<handshake/>, SIZE=12, XMLNS=null, PRIORITY=NORMAL, PERMISSION=NONE, TYPE=null, STABLE_ID=null
java.lang.NullPointerException
    at tigase.server.Packet.packRouted(Packet.java:1004)
    at tigase.cluster.ClusterConnectionManager.processPacket(ClusterConnectionnager.java:406)
    at tigase.server.AbstractMessageReceiverSQueueListener.run(AbstractMessageReceiver.java:1398)
```

Activities

Wojciech Kapcia (Tigase) added "Related" Customers/carnow-inc#148 1 year ago
Andrzej Wójcik (Tigase) changed state to 'In Progress' 1 year ago
Previous Value Current Value
Open

In Progress
Andrzej Wójcik (Tigase) changed state to 'In QA' 1 year ago
Previous Value Current Value
In Progress

In QA
Andrzej Wójcik (Tigase) commented 1 year ago

I've added check to ensure only <cluster/> and <route/> packets are redelivered as according to processPacket() method, all other packets are wrapped as one of those. Remaining packets are packets used for handshaked or ping and should be dropped.
Wojciech Kapcia (Tigase) changed state to 'Closed' 1 year ago
Previous Value Current Value
In QA

Closed
Wojciech Kapcia (Tigase) added to iteration "tigase-server-8.4.0" 1 year ago
Login to comment

Previous Value	Current Value
Open	In Progress

Previous Value	Current Value
In Progress	In QA

Previous Value	Current Value
In QA	Closed

Type	Bug
Priority	Normal
Assignee	Andrzej Wójcik (Tigase)
Version	8.4.0, 8.2.x
Server Version	8.4.0, 8.2.x
Target Release	1.0
Sprints	n/a
Customer	n/a

Iterations

tigase-server-8.4.0 Closed

Issue Votes (0)

Watchers (3)

Reference

tigase/_server/server-core#1513