Retrying undelivered packets should only happen for payload packets in cluster (#1513)

Closed

Activities

wojciech.kapcia@tigase.net opened 8 months ago

In case of writing packet to socket problem, packet may be slated for re-delivery, but this only should apply to proper cluster payload packets (IQ and message stanzas).


Context: there was a problem with connectivity, which resulted in NPE because tigase tried to re-deliver  `<handshake/>` packet, which should have been dropped. What's more, particular point may result in subsequent closing of the connection:

```
[2023-12-09 16:33:11:374] [SEVERE ] [in_10-cl-comp ] AbstractMessageReceiver$QueueListener.run(): Exception during packet processing: from-null, to=null, serverAuthorisedStanzaFrom-Optional. empty, DATA=<handshake/>, SIZE=12, XMLNS=null, PRIORITY=NORMAL, PERMISSION=NONE, TYPE=null, STABLE_ID=null
java.lang.NullPointerException
    at tigase.server.Packet.packRouted(Packet.java:1004)
    at tigase.cluster.ClusterConnectionManager.processPacket(ClusterConnectionnager.java:406)
    at tigase.server.AbstractMessageReceiverSQueueListener.run(AbstractMessageReceiver.java:1398)
```

wojciech.kapcia@tigase.net added "Related" Customers/carnow-inc#148 8 months ago

Referenced from commit 8 months ago

Improved redelivery mechanism for cluster connections #1513

Andrzej Wójcik (Tigase) committed 8 months ago

65787881

Andrzej Wójcik (Tigase) changed state to 'In Progress' 8 months ago

Previous Value	Current Value
Open	In Progress

Andrzej Wójcik (Tigase) changed state to 'In QA' 8 months ago

Previous Value	Current Value
In Progress	In QA

Andrzej Wójcik (Tigase) commented 8 months ago

I've added check to ensure only <cluster/> and <route/> packets are redelivered as according to processPacket() method, all other packets are wrapped as one of those. Remaining packets are packets used for handshaked or ping and should be dropped.

Referenced from commit 8 months ago

Improved redelivery mechanism for cluster connections #1513

Andrzej Wójcik (Tigase) committed 8 months ago

83bc477e

wojciech.kapcia@tigase.net changed state to 'Closed' 4 months ago

Previous Value	Current Value
In QA	Closed

wojciech.kapcia@tigase.net added to iteration "tigase-server-8.4.0" 3 months ago

Type	Bug
Priority	Normal
Assignee	Andrzej Wójcik (Tigase)
Version	8.4.0, 8.2.x
Server Version	8.4.0, 8.2.x
Target Release	1.0
Sprints	n/a
Customer	n/a

Iterations

tigase-server-8.4.0 Closed

Customers/carnow-inc#148 You are not authorized to access this issue

Issue Votes (0)

Watchers (3)

Reference

tigase/_server/server-core#1513