Return better SASL error for accounts pending confirmation (#1511)

Andrzej Wójcik (Tigase) opened 1 year ago

It was brought to my attention that if account is waiting for confirmation (and due to that authentication is failing), currently Tigase reports back temporary-auth-failure error. This error suggest that without any user interaction, account may become accessible as the "issue" is only temporary.

For blocked accounts, Tigase returns account-disabled error that notifies user that account is blocked and it needs to take action to actually "fix" account state.

Due to the nature of the error (account pending confirmation), we should be returning account-disabled to let user know that some action has to be taken to enable his account.

Andrzej Wójcik (Tigase) changed state to 'In Progress' 1 year ago

Previous Value	Current Value
Open	In Progress

Andrzej Wójcik (Tigase) commented 1 year ago

After short discussion with @bmalkow we decided that we can make this change without any impact on the account security.

Referenced from commit 1 year ago

Return `account-disabled` SASL error for accounts pending confirmation #1511

Andrzej Wójcik (Tigase) committed 1 year ago

090cec61

Andrzej Wójcik (Tigase) changed state to 'In QA' 1 year ago

Previous Value	Current Value
In Progress	In QA

wojciech.kapcia@tigase.net batch edited 7 months ago

Name	Previous Value	Current Value
Iterations	empty	tigase-server-8.4.0

wojciech.kapcia@tigase.net batch edited 7 months ago

Name	Previous Value	Current Value
Version	8.4.0	tigase-server-8.4.0

Andrzej Wójcik (Tigase) changed state to 'Closed' 7 months ago

Previous Value	Current Value
In QA	Closed

Referenced from commit 1 month ago

remove pack200 as it breaks package installation when conditions are used, fix #1511 : HTTP API component breaks the installer

Wojciech Kapcia committed 1 decade ago

f2b9cbe2

Referenced from commit 1 month ago

Merge branch 'master' into jdk7

# By Eric Dziewa (8) and others
# Via Andrzej Wójcik (1) and Eric Dziewa (1)
* master:
  Fix #1518 Message carbon does not work with ACS
  change MySQL cluster table fields types to correctly handle data, fix #1501: JDBC exception in tigase cluster
  avoid generating ChangeLog under windows; include tigase-acs in distribution archives
  prepare for next development iteration
  prepare for next development iteration
  Update licence dependency to beta3.
  Fix a dependency.
  Update xmltools dependency.
  Update dependencies.
  Update dependencies to beta3 versions.
  Update dependencies to beta3 versions.
  include missing ACS depencency in distribution package; fix #1509: tigase-acs,jar is not installed to jars directory
  remove pack200 as it breaks package installation when conditions are used, fix #1511: HTTP API component breaks the installer
  include resources (scripts, config files, database schemas) from dependencies (HTTP API, MUC, socks5)
  add team members, fix Task #1510: Installer fixes
  fix checking for OSGi mode (#1508 - Cannot find TIGASE_HOME after installation)

Andrzej Wójcik committed 1 decade ago

bbbd8d6a

Type	Task
Priority	Normal
Assignee	Andrzej Wójcik (Tigase)
Version	tigase-server-8.4.0
Server Version	8.4.0
Target Release	1.0
Sprints	n/a
Customer	n/a

Iterations

tigase-server-8.4.0 Closed

Issue Votes (0)

Watchers (4)

Reference

tigase/_server/server-core#1511