Projects tigase _server server-core Issues #1362
Add support for banning users with support of xmppbl.org (#1362)
Andrzej Wójcik (Tigase) opened 2 years ago

This task is for preparing generic/common support for this feature (ie. fetching and subscribing mechanism, to be able to have a single repository of block list for the whole server).

  • Andrzej Wójcik (Tigase) commented 2 years ago

    Feature is implemented and tests were created in TTS-NG. I've tested it locally (on a single node deployment) and using test cases and all was working fine.

    PR https://github.com/tigase/tigase-server/pull/209

  • Wojciech Kapcia (Tigase) commented 2 years ago

    Looks OK. Minor comments.

    Please include documentation (what it is, what's the purpose, how it operates / how to configure it);

    EDIT: shouldn't we add xmppbl.org by default to repository (possibly as configurable option like useDefaultServers)? I think it would make usage of the feature easier.

  • Andrzej Wójcik (Tigase) commented 2 years ago

    shouldn't we add xmppbl.org by default to repository (possibly as configurable option like useDefaultServers)? I think it would make usage of the feature easier.

    I'm against adding any block list automatically, especially those that are out of our control. Moreover, I doesn't feel OK to add sending any requests to other services just because someone could decide it is useful. Some people (even not understanding what it does and how) could consider this harmful and privacy invasive.

  • Andrzej Wójcik (Tigase) commented 2 years ago

    Moreover, even other developers, ie. Prosody developers behind this feature/service, decided not to include their own service as a hardcoded blocklist.

  • Wojciech Kapcia (Tigase) commented 2 years ago

    OK, understood.

    Still, any sort of documentation how to use it would be more than welcome then.

  • Andrzej Wójcik (Tigase) commented 2 years ago

    I've improved RTBL implementation and added documentation

  • Wojciech Kapcia (Tigase) commented 2 years ago

    Thank you, merged.

  • Wojciech Kapcia (Tigase) batch edited 1 year ago
    Name Previous Value Current Value
    Iterations
    empty
    tigase-server-8.4.0
  • Wojciech Kapcia (Tigase) changed state to 'Closed' 1 year ago
    Previous Value Current Value
    In QA
    Closed
issue 1 of 1
Type
Task
Priority
Normal
Assignee
Version
tigase-server-8.4.0
Iterations
Issue Votes (0)
Watchers (2)
Reference
tigase/_server/server-core#1362
Please wait...
Page is in error, reload to recover