Projects tigase _server server-core Issues #1311
Tigase tries to send presence without "from" (#1311)
wojciech.kapcia@tigase.net opened 3 years ago
[2022-02-21 06:08:36:473] [WARNING ] [              in_6-s2s ] S2SConnectionManager.processPacket(): Missing 'from' attribute, ignoring packet...from=sess-man@ip-172-31-20-109.us-west-2.compute.internal, to=null, serverAuthorisedStanzaFrom=Optional.empty, DATA=<presence type="unavailable" to="…@xmpp.…" xmlns="jabber:client"/>, SIZE=79, XMLNS=jabber:client, PRIORITY=PRESENCE, PERMISSION=AUTH, TYPE=unavailable, STABLE_ID=null
wojciech.kapcia@tigase.net commented 3 years ago

It looks like Tigase is generating probes without proper from:

[2022-02-21 06:07:51.642] [TRACE] [            in_6-s2s] tigase.server.xmppserver.CIDConnections.sendPacket(): Packet: from=null, to=null, serverAuthorisedStanzaFrom=Optional.empty, DATA=<presence type="unavailable" from="yinuo@tigase.im/Sendoh Akira" to="zhangmiao@xmpp.social"><show>xa</show><c xmlns="http://jabber.org/protocol/caps" ver="iDsQ5ylL+2GzLhWorgiCTv4m8oM=" hash="sha-1" node="http://tigase.org/TigaseSwiftX"/><x xmlns="vcard-temp:x:update"><photo>fe3e5088def3d394791db994a959c993565e3047</photo></x></presence>, SIZE=338, XMLNS=jabber:client, PRIORITY=PRESENCE, PERMISSION=NONE, TYPE=unavailable, STABLE_ID=null sent over connection: CID: tigase.im@xmpp.social, IN: 1, OUT: 1, authenticated: true, remote-session-id: 15942474874901408753, streamNegotiationCompleted: true, jid: tigase.im@xmpp.social, S2SIOService, UniqueId: 172.25.0.2_33106_31.172.31.205_5269, type: -> outgoing (connect), TLS: SocketIO, ID: tigase.im@xmpp.social/a524326a-30a8-45bb-acbf-a69cfe7a511e, connected Socket[addr=/31.172.31.205,port=5269,localport=33106]
…
[2022-02-21 06:07:54.376] [TRACE] [jabber:iq:roster-proc-1] tigase.xmpp.impl.roster.RosterFlat.loadUserRoster(): Loaded user yinuo@tigase.im/Sendoh Akira roster: <contact weight="1.0" last-seen="1000" jid="bella0627@hookipa.net" subs="none_pre_approved" preped="simple" name="bella0627" activity="1.0"/><contact weight="1.0" last-seen="1000" jid="linqing@xmpp.social" subs="from_pending_out" preped="simple" name="linqing" activity="1.0"/><contact weight="1.0" last-seen="1000" jid="bxin@wiuwiu.de" subs="from_pending_out" preped="simple" name="bxin" activity="1.0"/><contact weight="1.0" last-seen="1645409092003" jid="LiHui1919@hookipa.net" subs="both" preped="simple" name="LiHui1919" activity="1.0"/><contact weight="1.0" last-seen="1000" jid="pxiya@tigase.im" subs="from_pending_out" preped="simple" name="pxiya" activity="1.0"/><contact weight="1.0" last-seen="1000" jid="Lim@nerdculture.de" subs="from" preped="simple" name="Lim" activity="1.0"/><contact weight="1.0" last-seen="1645423491408" jid="ly201206@hookipa.net" subs="both" preped="simple" name="ly201206" activity="1.0"/><contact weight="1.0" last-seen="1000" jid="xiangwei@chatterboxtown.us" subs="from_pending_out" preped="simple" name="xiangwei" activity="1.0"/><contact weight="1.0" last-seen="1000" jid="shangze22@chatterboxtown.us" subs="from_pending_out" preped="simple" name="shangze22" activity="1.0"/><contact weight="1.0" last-seen="1000" jid="brian345345@chatterboxtown.us" subs="from_pending_out" preped="simple" name="Zjy" activity="1.0"/><contact weight="1.0" last-seen="1000" jid="max2022@chatterboxtown.us" subs="from_pending_out" preped="simple" name="GTY" activity="1.0"/><contact weight="1.0" last-seen="1000" jid="Californiasun@hookipa.net" subs="from_pending_out" preped="simple" name="lzs " activity="1.0"/><contact weight="1.0" last-seen="1000" jid="zhangmiao@xmpp.social" subs="from_pending_out" preped="simple" name="zhangmiao" activity="1.0"/><contact weight="1.0" last-seen="1000" jid="Dongyilin@hookipa.net" subs="none_pending_out_pre_approved" preped="simple" name="Dongyilin" activity="1.0"/><contact weight="1.0" last-seen="1000" jid="hanxing22@xmpp.social" subs="none_pending_out_pre_approved" preped="simple" name="hanxing22" activity="1.0"/><contact weight="1.0" last-seen="1645423491199" jid="future620620@chatterboxtown.us" subs="both" preped="simple" name="ZY" activity="1.0"/><contact weight="1.0" last-seen="1645419969473" jid="nekomuraneko@tigase.im" subs="both" preped="simple" name="nekomuraneko" activity="1.0"/><contact weight="1.0" last-seen="1645416213245" jid="liuqiang@tigase.im" subs="both" preped="simple" name="liuqiang" activity="1.0"/><contact weight="1.0" last-seen="1000" jid="llcchh@chatterboxtown.us" subs="from_pending_out" preped="simple" name="llcchh" activity="1.0"/>
…
[2022-02-21 06:08:36.415] [TRACE] [presence-subscription-proc-1] tigase.xmpp.impl.roster.RosterFlat.saveUserRoster(): yinuo@tigase.im | Saving user roster: <contact weight="1.0" last-seen="1000" jid="bella0627@hookipa.net" subs="none_pre_approved" preped="simple" name="bella0627" activity="1.0"/><contact weight="1.0" last-seen="1000" jid="linqing@xmpp.social" subs="from_pending_out" preped="simple" name="linqing" activity="1.0"/><contact weight="1.0" last-seen="1000" jid="bxin@wiuwiu.de" subs="from_pending_out" preped="simple" name="bxin" activity="1.0"/><contact weight="1.0" last-seen="1645409092003" jid="LiHui1919@hookipa.net" subs="both" preped="simple" name="LiHui1919" activity="1.0"/><contact weight="1.0" last-seen="1000" jid="pxiya@tigase.im" subs="from_pending_out" preped="simple" name="pxiya" activity="1.0"/><contact weight="1.0" last-seen="1000" jid="Lim@nerdculture.de" subs="from" preped="simple" name="Lim" activity="1.0"/><contact weight="1.0" last-seen="1645423491408" jid="ly201206@hookipa.net" subs="both" preped="simple" name="ly201206" activity="1.0"/><contact weight="1.0" last-seen="1000" jid="xiangwei@chatterboxtown.us" subs="from_pending_out" preped="simple" name="xiangwei" activity="1.0"/><contact weight="1.0" last-seen="1000" jid="shangze22@chatterboxtown.us" subs="from_pending_out" preped="simple" name="shangze22" activity="1.0"/><contact weight="1.0" last-seen="1000" jid="brian345345@chatterboxtown.us" subs="from_pending_out" preped="simple" name="Zjy" activity="1.0"/><contact weight="1.0" last-seen="1000" jid="max2022@chatterboxtown.us" subs="from_pending_out" preped="simple" name="GTY" activity="1.0"/><contact weight="1.0" last-seen="1000" jid="Californiasun@hookipa.net" subs="from_pending_out" preped="simple" name="lzs " activity="1.0"/><contact weight="1.0" last-seen="1000" jid="zhangmiao@xmpp.social" subs="from_pending_out" preped="simple" name="zhangmiao" activity="1.0"/><contact weight="1.0" last-seen="1000" jid="Dongyilin@hookipa.net" subs="from_pending_out" preped="simple" name="Dongyilin" activity="1.0"/><contact weight="1.0" last-seen="1000" jid="hanxing22@xmpp.social" subs="none_pending_out_pre_approved" preped="simple" name="hanxing22" activity="1.0"/><contact weight="1.0" last-seen="1645423491199" jid="future620620@chatterboxtown.us" subs="both" preped="simple" name="ZY" activity="1.0"/><contact weight="1.0" last-seen="1645419969473" jid="nekomuraneko@tigase.im" subs="both" preped="simple" name="nekomuraneko" activity="1.0"/><contact weight="1.0" last-seen="1645416213245" jid="liuqiang@tigase.im" subs="both" preped="simple" name="liuqiang" activity="1.0"/><contact weight="1.0" last-seen="1000" jid="llcchh@chatterboxtown.us" subs="from_pending_out" preped="simple" name="llcchh" activity="1.0"/>
…
[2022-02-21 06:08:36.449] [TRACE] [presence-subscription-proc-1] tigase.xmpp.impl.PresenceAbstract.broadcastProbe(): yinuo@tigase.im | Sending presence probe to: ly201206@hookipa.net 
[2022-02-21 06:08:36.449] [TRACE] [        in_0-cl-comp] tigase.cluster.ClusterConnectionManager.processPacket(): Processing packet: from=null, to=null, serverAuthorisedStanzaFrom=Optional.empty, DATA=<cluster id="cl-767097" type="set" xmlns="tigase:cluster" from="pubsub@ip-172-31-20-109.us-west-2.compute.internal" to="pubsub@ip-172-31-38-91.us-west-2.compute.internal" pr="HIGH"><control><visited-nodes><node-id>pubsub@ip-172-31-20-109.us-west-2.compute.internal</node-id></visited-nodes><method-call name="pubsub-nodes-changed-cmd"><par name="userId">164241</par></method-call><first-node>pubsub@ip-172-31-20-109.us-west-2.compute.internal</first-node></control><data><caps-changed-cmd service-jid="yinuo@tigase.im" jid="dongyilin@hookipa.net/monocles chat[1.5].nDd6"><item node="http://blabber.im#s9wwbzZnxRoeCs3/INPZ7SBWhJk="/></caps-changed-cmd></data></cluster>, SIZE=668, XMLNS=tigase:cluster, PRIORITY=HIGH, PERMISSION=NONE, TYPE=set, STABLE_ID=null 
[2022-02-21 06:08:36.450] [TRACE] [presence-subscription-proc-1] tigase.xmpp.impl.PresenceAbstract.sendPresence(): Sending presence info: from=null, to=null, serverAuthorisedStanzaFrom=Optional.empty, DATA=<presence type="probe" from="yinuo@tigase.im" to="ly201206@hookipa.net" xmlns="jabber:client"/>, SIZE=95, XMLNS=jabber:client, PRIORITY=PRESENCE, PERMISSION=NONE, TYPE=probe, STABLE_ID=null 
[2022-02-21 06:08:36.450] [TRACE] [        in_0-cl-comp] tigase.cluster.ClusterElement.<init>(): Parsing cluster element: <cluster id="cl-767097" type="set" xmlns="tigase:cluster" from="pubsub@ip-172-31-20-109.us-west-2.compute.internal" to="pubsub@ip-172-31-38-91.us-west-2.compute.internal" pr="HIGH"><control><visited-nodes><node-id>pubsub@ip-172-31-20-109.us-west-2.compute.internal</node-id></visited-nodes><method-call name="pubsub-nodes-changed-cmd"><par name="userId">164241</par></method-call><first-node>pubsub@ip-172-31-20-109.us-west-2.compute.internal</first-node></control><data><caps-changed-cmd service-jid="yinuo@tigase.im" jid="dongyilin@hookipa.net/monocles chat[1.5].nDd6"><item node="http://blabber.im#s9wwbzZnxRoeCs3/INPZ7SBWhJk="/></caps-changed-cmd></data></cluster> 
[2022-02-21 06:08:36.450] [TRACE] [        in_0-cl-comp] tigase.cluster.ClusterElement.<init>(): First node found: pubsub@ip-172-31-20-109.us-west-2.compute.internal 
[2022-02-21 06:08:36.450] [TRACE] [        in_0-cl-comp] tigase.cluster.ClusterElement.<init>(): Found and added visited nodes: 1 
[2022-02-21 06:08:36.452] [TRACE] [        in_0-cl-comp] tigase.server.ConnectionManager.writePacketToSocket(): Writing packet: from=null, to=null, serverAuthorisedStanzaFrom=Optional.empty, DATA=<cluster id="cl-767097" type="set" xmlns="tigase:cluster" from="pubsub@ip-172-31-20-109.us-west-2.compute.internal" to="pubsub@ip-172-31-38-91.us-west-2.compute.internal" pr="HIGH"><control><visited-nodes><node-id>pubsub@ip-172-31-20-109.us-west-2.compute.internal</node-id></visited-nodes><method-call name="pubsub-nodes-changed-cmd"><par name="userId">164241</par></method-call><first-node>pubsub@ip-172-31-20-109.us-west-2.compute.internal</first-node></control><data><caps-changed-cmd service-jid="yinuo@tigase.im" jid="dongyilin@hookipa.net/monocles chat[1.5].nDd6"><item node="http://blabber.im#s9wwbzZnxRoeCs3/INPZ7SBWhJk="/></caps-changed-cmd></data></cluster>, SIZE=668, XMLNS=tigase:cluster, PRIORITY=HIGH, PERMISSION=NONE, TYPE=set, STABLE_ID=null [jid: ip-172-31-38-91.us-west-2.compute.internal, XMPPIOService, UniqueId: 172.25.0.2_51310_172.31.38.91_5277, type: -> outgoing (connect), SocketIO, ID: null, connected Socket[addr=ip-172-31-38-91.us-west-2.compute.internal/172.31.38.91,port=5277,localport=51310]] 
[2022-02-21 06:08:36.452] [TRACE] [presence-subscription-proc-1] tigase.xmpp.impl.PresenceAbstract.broadcastProbe(): yinuo@tigase.im | Sending intial presence to: ly201206@hookipa.net 
[2022-02-21 06:08:36.453] [TRACE] [presence-subscription-proc-1] tigase.xmpp.impl.PresenceAbstract.sendPresence(): Sending presence info: from=null, to=null, serverAuthorisedStanzaFrom=Optional.empty, DATA=<presence type="unavailable" to="ly201206@hookipa.net" xmlns="jabber:client"/>, SIZE=78, XMLNS=jabber:client, PRIORITY=PRESENCE, PERMISSION=NONE, TYPE=unavailable, STABLE_ID=null 
[2022-02-21 06:08:36.453] [TRACE] [presence-subscription-proc-1] tigase.cluster.SessionManagerClustered.containsJid(): Called for jid: future620620@chatterboxtown.us 
[2022-02-21 06:08:36.453] [TRACE] [presence-subscription-proc-1] tigase.xmpp.impl.PresenceAbstract.broadcastProbe(): yinuo@tigase.im | Sending presence probe to: future620620@chatterboxtown.us 
[2022-02-21 06:08:36.453] [TRACE] [presence-subscription-proc-1] tigase.xmpp.impl.PresenceAbstract.sendPresence(): Sending presence info: from=null, to=null, serverAuthorisedStanzaFrom=Optional.empty, DATA=<presence type="probe" from="yinuo@tigase.im" to="future620620@chatterboxtown.us" xmlns="jabber:client"/>, SIZE=105, XMLNS=jabber:client, PRIORITY=PRESENCE, PERMISSION=NONE, TYPE=probe, STABLE_ID=null 
[2022-02-21 06:08:36.453] [TRACE] [presence-subscription-proc-1] tigase.xmpp.impl.PresenceAbstract.broadcastProbe(): yinuo@tigase.im | Sending intial presence to: future620620@chatterboxtown.us 
[2022-02-21 06:08:36.453] [TRACE] [presence-subscription-proc-1] tigase.xmpp.impl.PresenceAbstract.sendPresence(): Sending presence info: from=null, to=null, serverAuthorisedStanzaFrom=Optional.empty, DATA=<presence type="unavailable" to="future620620@chatterboxtown.us" xmlns="jabber:client"/>, SIZE=88, XMLNS=jabber:client, PRIORITY=PRESENCE, PERMISSION=NONE, TYPE=unavailable, STABLE_ID=null 
[2022-02-21 06:08:36.454] [TRACE] [presence-subscription-proc-1] tigase.cluster.SessionManagerClustered.containsJid(): Called for jid: nekomuraneko@tigase.im 
[2022-02-21 06:08:36.454] [TRACE] [presence-subscription-proc-1] tigase.xmpp.impl.PresenceAbstract.requiresPresenceSending(): yinuo@tigase.im/Sendoh Akira | buddy: nekomuraneko@tigase.im is online (sys): false 
[2022-02-21 06:08:36.454] [TRACE] [presence-subscription-proc-1] tigase.xmpp.impl.PresenceAbstract.broadcastProbe(): yinuo@tigase.im | Skipping sending initial presence and probe to: nekomuraneko@tigase.im 
[2022-02-21 06:08:36.454] [TRACE] [presence-subscription-proc-1] tigase.cluster.SessionManagerClustered.containsJid(): Called for jid: liuqiang@tigase.im 
[2022-02-21 06:08:36.454] [TRACE] [presence-subscription-proc-1] tigase.xmpp.impl.PresenceAbstract.requiresPresenceSending(): yinuo@tigase.im/Sendoh Akira | buddy: liuqiang@tigase.im is online (sys): false 
[2022-02-21 06:08:36.454] [TRACE] [presence-subscription-proc-1] tigase.xmpp.impl.PresenceAbstract.broadcastProbe(): yinuo@tigase.im | Skipping sending initial presence and probe to: liuqiang@tigase.im 
[2022-02-21 06:08:36.454] [TRACE] [presence-subscription-proc-1] tigase.cluster.SessionManagerClustered.containsJid(): Called for jid: linqing@xmpp.social 
[2022-02-21 06:08:36.454] [TRACE] [presence-subscription-proc-1] tigase.xmpp.impl.PresenceAbstract.broadcastProbe(): yinuo@tigase.im | Sending initial presence to: linqing@xmpp.social 
[2022-02-21 06:08:36.454] [TRACE] [presence-subscription-proc-1] tigase.xmpp.impl.PresenceAbstract.sendPresence(): Sending presence info: from=null, to=null, serverAuthorisedStanzaFrom=Optional.empty, DATA=<presence type="unavailable" to="linqing@xmpp.social" xmlns="jabber:client"/>, SIZE=77, XMLNS=jabber:client, PRIORITY=PRESENCE, PERMISSION=NONE, TYPE=unavailable, STABLE_ID=null 
[2022-02-21 06:08:36.454] [TRACE] [presence-subscription-proc-1] tigase.cluster.SessionManagerClustered.containsJid(): Called for jid: bxin@wiuwiu.de 
[2022-02-21 06:08:36.454] [TRACE] [presence-subscription-proc-1] tigase.xmpp.impl.PresenceAbstract.broadcastProbe(): yinuo@tigase.im | Sending initial presence to: bxin@wiuwiu.de 
[2022-02-21 06:08:36.455] [TRACE] [presence-subscription-proc-1] tigase.xmpp.impl.PresenceAbstract.sendPresence(): Sending presence info: from=null, to=null, serverAuthorisedStanzaFrom=Optional.empty, DATA=<presence type="unavailable" to="bxin@wiuwiu.de" xmlns="jabber:client"/>, SIZE=72, XMLNS=jabber:client, PRIORITY=PRESENCE, PERMISSION=NONE, TYPE=unavailable, STABLE_ID=null 
[2022-02-21 06:08:36.455] [TRACE] [presence-subscription-proc-1] tigase.cluster.SessionManagerClustered.containsJid(): Called for jid: pxiya@tigase.im 
[2022-02-21 06:08:36.455] [TRACE] [presence-subscription-proc-1] tigase.xmpp.impl.PresenceAbstract.broadcastProbe(): yinuo@tigase.im | Sending initial presence to: pxiya@tigase.im 
[2022-02-21 06:08:36.455] [TRACE] [presence-subscription-proc-1] tigase.xmpp.impl.PresenceAbstract.sendPresence(): Sending presence info: from=null, to=null, serverAuthorisedStanzaFrom=Optional.empty, DATA=<presence type="unavailable" to="pxiya@tigase.im" xmlns="jabber:client"/>, SIZE=73, XMLNS=jabber:client, PRIORITY=PRESENCE, PERMISSION=NONE, TYPE=unavailable, STABLE_ID=null 
[2022-02-21 06:08:36.455] [TRACE] [presence-subscription-proc-1] tigase.cluster.SessionManagerClustered.containsJid(): Called for jid: Lim@nerdculture.de 
[2022-02-21 06:08:36.455] [TRACE] [presence-subscription-proc-1] tigase.xmpp.impl.PresenceAbstract.broadcastProbe(): yinuo@tigase.im | Sending initial presence to: Lim@nerdculture.de 
[2022-02-21 06:08:36.455] [TRACE] [presence-subscription-proc-1] tigase.xmpp.impl.PresenceAbstract.sendPresence(): Sending presence info: from=null, to=null, serverAuthorisedStanzaFrom=Optional.empty, DATA=<presence type="unavailable" to="Lim@nerdculture.de" xmlns="jabber:client"/>, SIZE=76, XMLNS=jabber:client, PRIORITY=PRESENCE, PERMISSION=NONE, TYPE=unavailable, STABLE_ID=null 
[2022-02-21 06:08:36.456] [TRACE] [presence-subscription-proc-1] tigase.cluster.SessionManagerClustered.containsJid(): Called for jid: xiangwei@chatterboxtown.us 
[2022-02-21 06:08:36.456] [TRACE] [presence-subscription-proc-1] tigase.xmpp.impl.PresenceAbstract.broadcastProbe(): yinuo@tigase.im | Sending initial presence to: xiangwei@chatterboxtown.us 
[2022-02-21 06:08:36.456] [TRACE] [presence-subscription-proc-1] tigase.xmpp.impl.PresenceAbstract.sendPresence(): Sending presence info: from=null, to=null, serverAuthorisedStanzaFrom=Optional.empty, DATA=<presence type="unavailable" to="xiangwei@chatterboxtown.us" xmlns="jabber:client"/>, SIZE=84, XMLNS=jabber:client, PRIORITY=PRESENCE, PERMISSION=NONE, TYPE=unavailable, STABLE_ID=null 
[2022-02-21 06:08:36.456] [TRACE] [presence-subscription-proc-1] tigase.cluster.SessionManagerClustered.containsJid(): Called for jid: shangze22@chatterboxtown.us 
[2022-02-21 06:08:36.456] [TRACE] [presence-subscription-proc-1] tigase.xmpp.impl.PresenceAbstract.broadcastProbe(): yinuo@tigase.im | Sending initial presence to: shangze22@chatterboxtown.us 
[2022-02-21 06:08:36.456] [TRACE] [presence-subscription-proc-1] tigase.xmpp.impl.PresenceAbstract.sendPresence(): Sending presence info: from=null, to=null, serverAuthorisedStanzaFrom=Optional.empty, DATA=<presence type="unavailable" to="shangze22@chatterboxtown.us" xmlns="jabber:client"/>, SIZE=85, XMLNS=jabber:client, PRIORITY=PRESENCE, PERMISSION=NONE, TYPE=unavailable, STABLE_ID=null 
[2022-02-21 06:08:36.456] [TRACE] [presence-subscription-proc-1] tigase.cluster.SessionManagerClustered.containsJid(): Called for jid: brian345345@chatterboxtown.us 
[2022-02-21 06:08:36.456] [TRACE] [presence-subscription-proc-1] tigase.xmpp.impl.PresenceAbstract.broadcastProbe(): yinuo@tigase.im | Sending initial presence to: brian345345@chatterboxtown.us 
[2022-02-21 06:08:36.456] [TRACE] [presence-subscription-proc-1] tigase.xmpp.impl.PresenceAbstract.sendPresence(): Sending presence info: from=null, to=null, serverAuthorisedStanzaFrom=Optional.empty, DATA=<presence type="unavailable" to="brian345345@chatterboxtown.us" xmlns="jabber:client"/>, SIZE=87, XMLNS=jabber:client, PRIORITY=PRESENCE, PERMISSION=NONE, TYPE=unavailable, STABLE_ID=null 
[2022-02-21 06:08:36.456] [TRACE] [presence-subscription-proc-1] tigase.cluster.SessionManagerClustered.containsJid(): Called for jid: max2022@chatterboxtown.us 
[2022-02-21 06:08:36.456] [TRACE] [presence-subscription-proc-1] tigase.xmpp.impl.PresenceAbstract.broadcastProbe(): yinuo@tigase.im | Sending initial presence to: max2022@chatterboxtown.us 
[2022-02-21 06:08:36.456] [TRACE] [presence-subscription-proc-1] tigase.xmpp.impl.PresenceAbstract.sendPresence(): Sending presence info: from=null, to=null, serverAuthorisedStanzaFrom=Optional.empty, DATA=<presence type="unavailable" to="max2022@chatterboxtown.us" xmlns="jabber:client"/>, SIZE=83, XMLNS=jabber:client, PRIORITY=PRESENCE, PERMISSION=NONE, TYPE=unavailable, STABLE_ID=null 
[2022-02-21 06:08:36.456] [TRACE] [presence-subscription-proc-1] tigase.cluster.SessionManagerClustered.containsJid(): Called for jid: Californiasun@hookipa.net 
[2022-02-21 06:08:36.456] [TRACE] [presence-subscription-proc-1] tigase.xmpp.impl.PresenceAbstract.broadcastProbe(): yinuo@tigase.im | Sending initial presence to: Californiasun@hookipa.net 
[2022-02-21 06:08:36.457] [TRACE] [presence-subscription-proc-1] tigase.xmpp.impl.PresenceAbstract.sendPresence(): Sending presence info: from=null, to=null, serverAuthorisedStanzaFrom=Optional.empty, DATA=<presence type="unavailable" to="Californiasun@hookipa.net" xmlns="jabber:client"/>, SIZE=83, XMLNS=jabber:client, PRIORITY=PRESENCE, PERMISSION=NONE, TYPE=unavailable, STABLE_ID=null 
[2022-02-21 06:08:36.457] [TRACE] [presence-subscription-proc-1] tigase.cluster.SessionManagerClustered.containsJid(): Called for jid: zhangmiao@xmpp.social 
[2022-02-21 06:08:36.457] [TRACE] [presence-subscription-proc-1] tigase.xmpp.impl.PresenceAbstract.broadcastProbe(): yinuo@tigase.im | Sending initial presence to: zhangmiao@xmpp.social 
[2022-02-21 06:08:36.457] [TRACE] [presence-subscription-proc-1] tigase.xmpp.impl.PresenceAbstract.sendPresence(): Sending presence info: from=null, to=null, serverAuthorisedStanzaFrom=Optional.empty, DATA=<presence type="unavailable" to="zhangmiao@xmpp.social" xmlns="jabber:client"/>, SIZE=79, XMLNS=jabber:client, PRIORITY=PRESENCE, PERMISSION=NONE, TYPE=unavailable, STABLE_ID=null 
[2022-02-21 06:08:36.457] [TRACE] [presence-subscription-proc-1] tigase.cluster.SessionManagerClustered.containsJid(): Called for jid: Dongyilin@hookipa.net 
[2022-02-21 06:08:36.457] [TRACE] [presence-subscription-proc-1] tigase.xmpp.impl.PresenceAbstract.broadcastProbe(): yinuo@tigase.im | Sending initial presence to: Dongyilin@hookipa.net 
[2022-02-21 06:08:36.457] [TRACE] [presence-subscription-proc-1] tigase.xmpp.impl.PresenceAbstract.sendPresence(): Sending presence info: from=null, to=null, serverAuthorisedStanzaFrom=Optional.empty, DATA=<presence type="unavailable" to="Dongyilin@hookipa.net" xmlns="jabber:client"/>, SIZE=79, XMLNS=jabber:client, PRIORITY=PRESENCE, PERMISSION=NONE, TYPE=unavailable, STABLE_ID=null 
[2022-02-21 06:08:36.457] [TRACE] [presence-subscription-proc-1] tigase.cluster.SessionManagerClustered.containsJid(): Called for jid: llcchh@chatterboxtown.us 
[2022-02-21 06:08:36.457] [TRACE] [presence-subscription-proc-1] tigase.xmpp.impl.PresenceAbstract.broadcastProbe(): yinuo@tigase.im | Sending initial presence to: llcchh@chatterboxtown.us 
[2022-02-21 06:08:36.457] [TRACE] [presence-subscription-proc-1] tigase.xmpp.impl.PresenceAbstract.sendPresence(): Sending presence info: from=null, to=null, serverAuthorisedStanzaFrom=Optional.empty, DATA=<presence type="unavailable" to="llcchh@chatterboxtown.us" xmlns="jabber:client"/>, SIZE=82, XMLNS=jabber:client, PRIORITY=PRESENCE, PERMISSION=NONE, TYPE=unavailable, STABLE_ID=null 
[2022-02-21 06:08:36.457] [TRACE] [presence-subscription-proc-1] tigase.xmpp.impl.PresenceAbstract.sendPresence(): Sending presence info: from=null, to=null, serverAuthorisedStanzaFrom=Optional.empty, DATA=<presence type="subscribed" from="yinuo@tigase.im/Sendoh Akira" to="dongyilin@hookipa.net" xmlns="jabber:client"/>, SIZE=114, XMLNS=jabber:client, PRIORITY=NORMAL, PERMISSION=NONE, TYPE=subscribed, STABLE_ID=null 
[2022-02-21 06:08:36.457] [TRACE] [presence-subscription-proc-1] tigase.db.comp.ConfigRepository.getItem(): Getting item: tigase.im of items: [314.im, atomailer.com, beagle.im, choffee.co.uk, connyolivier.nl, default, eikeland.se, erythio.cz, foramina.net, hertay.fr, heyden.eu, hubbitus.info, im.flosoft.biz, jabber.me, jabber.one, jabber.today, kapcia.info, linuxonly.ru, lmrkes.com, logbox.pl, marsjanin.tk, negochat.com, pandion.im, polarities.name, siskin.im, sure.im, tigase.chat, tigase.eu, tigase.im, tigase.me, trina.nl, ubikuity.net, visibleblue.net, xmpp.cloud, zoologist.ru] 
[2022-02-21 06:08:36.457] [TRACE] [presence-subscription-proc-1] tigase.xmpp.impl.JabberIqPrivacy.filter(): Checking outbound packet: from=null, to=c2s@ip-172-31-20-109.us-west-2.compute.internal/172.25.0.2_5223_221.222.21.30_34081, serverAuthorisedStanzaFrom=Optional.empty, DATA=<iq type="set" id="rsttig3" to="yinuo@tigase.im/Sendoh Akira" xmlns="jabber:client"><query ver="eee822eb35326fbf43e39b00674b9b8b" xmlns="jabber:iq:roster"><item name="Dongyilin" subscription="from" jid="Dongyilin@hookipa.net" ask="subscribe"/></query></iq>, SIZE=256, XMLNS=jabber:client, PRIORITY=NORMAL, PERMISSION=AUTH, TYPE=set, STABLE_ID=null 
[2022-02-21 06:08:36.457] [TRACE] [ in_5-message-router] tigase.server.MessageRouter.processPacket(): Processing packet: from=null, to=null, serverAuthorisedStanzaFrom=Optional.empty, DATA=<message to="dongyilin@hookipa.net/monocles chat[1.5].nDd6" type="headline" from="yinuo@tigase.im" id="62349" xmlns="jabber:client"><event xmlns="http://jabber.org/protocol/pubsub#event"><items node="urn:xmpp:avatar:metadata"><item id="fe3e5088def3d394791db994a959c993565e3047"><metadata xmlns="urn:xmpp:avatar:metadata"><info type="image/jpeg" bytes="20094" width="256" height="256" id="8130833b59e38387e1869cf63f3cd2306023ea30"/><info type="image/png" bytes="5824" width="48" height="48" id="fe3e5088def3d394791db994a959c993565e3047"/></metadata></item></items></event></message>, SIZE=581, XMLNS=jabber:client, PRIORITY=NORMAL, PERMISSION=NONE, TYPE=headline, STABLE_ID=null 
…
[2022-02-21 06:08:36.461] [TRACE] [presence-subscription-proc-1] tigase.xmpp.impl.JabberIqPrivacy.filter(): Checking outbound packet: from=null, to=null, serverAuthorisedStanzaFrom=Optional.empty, DATA=<presence type="unavailable" to="zhangmiao@xmpp.social" xmlns="jabber:client"/>, SIZE=79, XMLNS=jabber:client, PRIORITY=PRESENCE, PERMISSION=AUTH, TYPE=unavailable, STABLE_ID=null
…
[2022-02-21 06:08:36.469] [TRACE] [ in_4-message-router] tigase.server.MessageRouter.processPacket(): Processing packet: from=sess-man@ip-172-31-20-109.us-west-2.compute.internal, to=null, serverAuthorisedStanzaFrom=Optional.empty, DATA=<presence type="unavailable" to="zhangmiao@xmpp.social" xmlns="jabber:client"/>, SIZE=79, XMLNS=jabber:client, PRIORITY=PRESENCE, PERMISSION=AUTH, TYPE=unavailable, STABLE_ID=null
[2022-02-21 06:08:36.469] [TRACE] [ in_4-message-router] tigase.server.MessageRouter.getLocalComponent(): Called for : zhangmiao@xmpp.social
wojciech.kapcia@tigase.net commented 3 years ago

It seems that tigase.xmpp.impl.PresenceAbstract#sendPresence(tigase.xmpp.StanzaType, tigase.xmpp.jid.JID, tigase.xmpp.jid.JID, java.util.Queue<tigase.server.Packet>, tigase.xml.Element) was the mail culprit - there were a couple of calls to this method with null passed as from (presence probes), which then caused the error. I added proper from (BareJID/FullJID where needed) in all places and added check/requirement in the method itself to require from and to attributes

@andrzej.wojcik could you take a look at https://github.com/tigase/tigase-server/pull/139 ?

Andrzej Wójcik (Tigase) commented 3 years ago

I've added a few comments to the changes that I'm not sure are correct.

wojciech.kapcia@tigase.net commented 3 years ago

Merged.

issue 1 of 1
Type
Bug
Priority
Normal
Assignee
Version
tigase-server-8.2.0
Spent time
3h 45m
Issue Votes (0)
Watchers (0)
Reference
tigase/_server/server-core#1311
Please wait...
Page is in error, reload to recover