XMPPProcessorException: XMPP error condition: bad-request (#1308)

Wojciech Kapcia (Tigase) opened 3 years ago

tigase.xmpp.XMPPProcessorException: XMPP error condition: bad-request 
	at tigase.xmpp.impl.MIXProcessor.lambda$process$3(MIXProcessor.java:116)
	at java.base/java.util.Optional.orElseThrow(Unknown Source)
	at tigase.xmpp.impl.MIXProcessor.process(MIXProcessor.java:116)
	at tigase.server.xmppsession.SessionManager$ProcessorWorkerThread.process(SessionManager.java:2685)
	at tigase.util.processing.WorkerThread.run(WorkerThread.java:67)

Activities

Wojciech Kapcia (Tigase) commented 3 years ago

[2022-02-09 16:41:55:394] [WARNING ] [urn:xmpp:mix:pam:2-proc-0 ] SessionManager$ProcessorWorkerThread.process(): Exception during packet processing: from=c2s@ip-172-31-38-91.us-west-2.compute.internal/172.29.0.2_5222_172.31.34.33_8068, to=sess-man@ip-172-31-38-91.us-west-2.compute.internal, serverAuthorisedStanzaFrom=Optional[andrey@xmpp.cloud/mobile], DATA=<iq xmlns="jabber:client" type="set" to="andrey@xmpp.cloud" id="B448D2CA-D8E0-4951-99E8-7B55DC49D8A3" from="andrey@xmpp.cloud/mobile"><client-join channel="cccda06d-3994-43e5-abc7-9337192aadf7@mix.xmpp.cloud" xmlns="urn:xmpp:mix:pam:2"><join xmlns="urn:xmpp:mix:core:q"><nick>test_nick</nick><subscribe node="urn:xmpp:mix:nodes:messages"/><subscribe node="urn:xmpp:mix:nodes:presence"/><subscribe node="urn:xmpp:mix:nodes:participants"/><subscribe node="urn:xmpp:mix:nodes:subject"/><subscribe node="urn:xmpp:mix:nodes:config"/></join></client-join></iq>, SIZE=554, XMLNS=jabber:client, PRIORITY=NORMAL, PERMISSION=AUTH, TYPE=set, STABLE_ID=ccac5132-7366-48c8-b011-8a7daf6f1648
tigase.xmpp.XMPPProcessorException: XMPP error condition: bad-request 
	at tigase.xmpp.impl.MIXProcessor.lambda$process$3(MIXProcessor.java:116)
	at java.base/java.util.Optional.orElseThrow(Unknown Source)
	at tigase.xmpp.impl.MIXProcessor.process(MIXProcessor.java:116)
	at tigase.server.xmppsession.SessionManager$ProcessorWorkerThread.process(SessionManager.java:2685)
	at tigase.util.processing.WorkerThread.run(WorkerThread.java:67)

Andrzej Wójcik (Tigase) commented 3 years ago

The cause of this issue is SessionManager reporting all XMPPException exceptions with level WARNING. Another issue, is that it is not sending error back to the packet sender.
Andrzej Wójcik (Tigase) commented 3 years ago

Issue fixed by adding error sending back to the user (where appropriate) and adjusted logging levels.
Andrzej Wójcik (Tigase) commented 3 years ago
@wojtek In XSF room was stated:

[2022-02-11 22:18:27] <Link Mauve>: Andrzej, I just received a “401 - auth: You must authorize session first.” from your in-room JID, were you doing anything special?

I suppose that this can be linked to NotAuthorized exception being caught and sending exceptions back to the MUC room.

Should we check it and do anything about that?
Wojciech Kapcia (Tigase) commented 3 years ago

Definitely we should check it. I saw a couple of notifications with "You must authorize session first." in the notifications.
Andrzej Wójcik (Tigase) commented 3 years ago

It looks like it never repeated, so we can assume that it was a temporary glitch due to server upgrade and restarting nodes.
Login to comment

Type	Bug
Priority	Normal
Assignee	Andrzej Wójcik (Tigase)
Version	tigase-server-8.2.0

Issue Votes (0)

Watchers (0)

Reference

tigase/_server/server-core#1308