Projects tigase _server server-core Issues #1301
Message Carbons for messages with type 'normal'? (#1301)
Closed
Bartosz Małkowski opened 3 years ago

Currently Message Carbons are created and delivered to all entities only if message type is chat. Should we also apply it to messages with type normal?

wojciech.kapcia@tigase.net commented 3 years ago

@andrzej.wojcik it seems this was changes in #issue #1029? As per 6.1 Recommended Rules :

A is eligible for carbons delivery if it does not contain a child element and if at least one of the following is true:

  • it is of type "chat".
  • it is of type "normal" and contains a element.
  • it contains payload elements typically used in IM (Message Delivery Receipts (XEP-0184) [3], Chat State Notifications (XEP-0085) [4], Chat Markers (XEP-0333) [5]).
  • it is of type "error" and it was sent in response to a that was eligible for carbons delivery.
  • it matches the MUC-related rules outlined below.

I guess we should probably adjust tigase.xmpp.impl.MessageCarbons#shouldSendCarbons to include normal type of messages with body as well?

Andrzej Wójcik (Tigase) commented 3 years ago

@wojtek Most likely we should. I do not recall if originally XEP stated that we should forward "normal" messages or if that was changed at some point.

issue 1 of 1
Type
New Feature
Priority
Normal
Assignee
Version
Candidate for next major release
Spent time
30m
Issue Votes (0)
Watchers (0)
Reference
tigase/_server/server-core#1301
Please wait...
Page is in error, reload to recover