MAM:2 archived messages redelivered after broken connection do not contain `<stanza-id/>` (#1295)

Closed

Activities

Andrzej Wójcik (Tigase) opened 3 years ago

Affected versions
tigase-issue #8.2.0

MAM:2 archived messages redelivered after broken connection do not contain <stanza-id/>. This is causing issues with the detection of redelivery and should not happen as we advertise and archive this message in MAM:2, which requires a stable stanza-id.

Andrzej Wójcik (Tigase) commented 3 years ago

I think this should fix the issue with <stanza-id/> being removed and should allow the server to keep knowledge of stable id in the internal variable in Packet.

Looking at the code, it looks like this was initially needed to remove stanza-id if delivery failed as redelivery would regenerate it. Currently it is no longer true, as we store messages in MAM archive at the same time as we process them even for offline messages.

wojciech.kapcia@tigase.net commented 3 years ago

I think it looks ok.

Type	Bug
Priority	Normal
Assignee	wojciech.kapcia@tigase.net
Version	tigase-server-8.2.0

Issue Votes (0)

Watchers (0)

Reference

tigase/_server/server-core#1295