Simplify and de-duplicate tigase.server.Command and tigase.server.DataForm API (#1291)

Wojciech Kapcia (Tigase) opened 4 years ago

Curently both of those APIs seems to share a lot of functionality. Quite possibly all data form handling could be moved to tigase.server.DataForm. We should also utilise more, if possible, provided builders. (We also have tigase.form.Form API, but it could be "too heavy", especially for Command objects, though ideally we should limit number of APIs doing the same thing…)

Intention for 8.3 is to come up with way forward and deprecating older APIs that will be removed.

Related
- Wrong field type for XEP-0157 entries (#1285) Closed

Activities

Andrzej Wójcik (Tigase) commented 4 years ago

DataForm contains a Builder class which has a more useful API than tigase.server.Command and tigase.server.DataForm. This new builder should be a preferred way to create forms. While it may be slightly heavier than using DataForm or Command APIs, usage of this API is easier to read and understand.
Wojciech Kapcia (Tigase) commented 4 years ago

The 3rd sentence states as much: "We should also utilise more, if possible, provided builders."...

The gist of the issue to somewhat organise what we have now (including Form API form tigase-utils) to ideally have only single, well documented API…
Wojciech Kapcia (Tigase) batch edited 2 years ago
Name Previous Value Current Value
Iterations
empty
tigase-server-8.4.0

Name	Previous Value	Current Value
Iterations	empty	tigase-server-8.4.0

Wojciech Kapcia (Tigase) batch edited 1 year ago

Name	Previous Value	Current Value
Iterations	tigase-server-8.4.0	tigase-server-8.5.0
Version	tigase-server-8.4.0	tigase-server-8.5.0

Wojciech Kapcia (Tigase) batch edited 7 days ago
Name Previous Value Current Value
Version

tigase-server-8.5.0

8.5.0
Login to comment

Name	Previous Value	Current Value
Version	tigase-server-8.5.0	8.5.0

Type	Task
Priority	Normal
Assignee	Wojciech Kapcia (Tigase)
Version	8.5.0

Iterations

tigase-server-8.5.0 Open

Issue Votes (0)

Watchers (2)

Reference

tigase/_server/server-core#1291