Projects tigase _server server-core Issues #1253
It seems that 'expired-processor' doesn't remove periodically expired messages (#1253)
wojciech.kapcia@tigase.net opened 4 years ago

As described in https://projects.tigase.net/issue/helpdeskpr-673#focus=Comments-4-29605.0-0 it seems that expired-processor doesn't remove the messages periodically.

Ideally, the mechanism shouldn't be triggered only by queue events like it's done currently.

Andrzej Wójcik (Tigase) commented 4 years ago

I've reimplemented expired messages queue by moving it to pool bean of MsgRepositoryIfc so that we will have a single blocking queue instead of multiple queues which need to be checked in loops or blocked on a separate lock (which was causing an issue).

Andrzej Wójcik (Tigase) commented 4 years ago

I think that the new implementation is ready for review. Changes are available in following PR:

https://github.com/tigase/tigase-server/pull/96 https://github.com/tigase/tigase-mongodb/pull/1

wojciech.kapcia@tigase.net commented 4 years ago

The changes look OK. There is a tiny suggestion if that's ok. Otherwise can be merged.

Andrzej Wójcik (Tigase) commented 4 years ago

Applied suggested change.

wojciech.kapcia@tigase.net commented 4 years ago

Merged.

issue 1 of 1
Type
Bug
Priority
Normal
Assignee
Version
tigase-server-8.2.0
Spent time
8h 15m
Issue Votes (0)
Watchers (0)
Reference
tigase/_server/server-core#1253
Please wait...
Page is in error, reload to recover