Statistics for module.process() (#1246)

Wojciech Kapcia (Tigase) opened 4 years ago

We currently have global statistics for component (packets in last second/minute/hour + average processing time). It would be handy for analysis of performance to have similar statistics on per-module basis (something similar to MethodStatistics)

Related
- MethodStatistics doesn't work well for interfaces with overloaded methods (#1245) Closed

Activities

Andrzej Wójcik (Tigase) commented 4 years ago

I've added statistics, but I'm not sure if it would be better to use class name (as I did) or short name, or bean name? Class name gives us the name of the actual class implementing module which would be nice to have and know if someone would overwrite or replace our class/module.

Changes are in issue #1246 branch.
Wojciech Kapcia (Tigase) commented 4 years ago
Class name is ok, though I would either remove package or used shorthand (though, I would lean towards former).

Usually we also get accompanying config file so we know if there some custom code.

So from:

pubsub/stanzaProcessor/tigase.pubsub.modules.NodeCreateModule/Excutions last hour=0

to:

pubsub/module/NodeCreateModule/Excutions last hour=0
Andrzej Wójcik (Tigase) commented 4 years ago

I've adjusted name of the class used in statistics
Wojciech Kapcia (Tigase) commented 4 years ago

merged.
Login to comment

Type	New Feature
Priority	Normal
Assignee	Wojciech Kapcia (Tigase)
Version	Candidate for next major release
Spent time	0
Subsystem	Kernel

Issue Votes (0)

Watchers (0)

Reference

tigase/_server/server-core#1246