Projects tigase _server server-core Issues #1246
Statistics for module.process() (#1246)
Closed
wojciech.kapcia@tigase.net opened 3 years ago

We currently have global statistics for component (packets in last second/minute/hour + average processing time). It would be handy for analysis of performance to have similar statistics on per-module basis (something similar to MethodStatistics)

Andrzej Wójcik (Tigase) commented 3 years ago

I've added statistics, but I'm not sure if it would be better to use class name (as I did) or short name, or bean name? Class name gives us the name of the actual class implementing module which would be nice to have and know if someone would overwrite or replace our class/module.

Changes are in issue #1246 branch.

wojciech.kapcia@tigase.net commented 3 years ago

Class name is ok, though I would either remove package or used shorthand (though, I would lean towards former).

Usually we also get accompanying config file so we know if there some custom code.

So from:

pubsub/stanzaProcessor/tigase.pubsub.modules.NodeCreateModule/Excutions last hour=0

to:

pubsub/module/NodeCreateModule/Excutions last hour=0
Andrzej Wójcik (Tigase) commented 3 years ago

I've adjusted name of the class used in statistics

wojciech.kapcia@tigase.net commented 3 years ago

merged.

issue 1 of 1
Type
New Feature
Priority
Normal
Assignee
Version
Candidate for next major release
Spent time
1h 15m
Subsystem
Kernel
Issue Votes (0)
Watchers (0)
Reference
tigase/_server/server-core#1246
Please wait...
Page is in error, reload to recover