NullPointerException in ClusterConnectionManager (#1244)

Activities

wojciech.kapcia@tigase.net opened 4 years ago

Affected versions
tigase-issue #8.1.3

[2021-04-09 13:00:45:800] [WARNING ] [ResultsListener-socketWriteThread-127 ] SocketThread$ResultsListener.run(): Protocol execution exception.
java.lang.NullPointerException
	at tigase.cluster.ClusterConnectionManager.processSocketData(ClusterConnectionManager.java:427)
	at tigase.server.ConnectionManager.packetsReady(ConnectionManager.java:347)
	at tigase.server.ConnectionManager.packetsReady(ConnectionManager.java:61)
	at tigase.net.IOService.call(IOService.java:202)
	at tigase.xmpp.XMPPIOService.call(XMPPIOService.java:146)
	at tigase.xmpp.XMPPIOService.call(XMPPIOService.java:51)
	at java.base/java.util.concurrent.FutureTask.run(FutureTask.java:264)
	at java.base/java.util.concurrent.Executors$RunnableAdapter.call(Executors.java:515)
	at java.base/java.util.concurrent.FutureTask.run(FutureTask.java:264)
	at java.base/java.util.concurrent.ThreadPoolExecutor.runWorker(ThreadPoolExecutor.java:1128)
	at java.base/java.util.concurrent.ThreadPoolExecutor$Worker.run(ThreadPoolExecutor.java:628)
	at java.base/ja

Andrzej Wójcik (Tigase) commented 3 years ago

I've applied a few protections. We will now catch NPE during "redelivery" to know which packets caused it. Additionally, I've stopped ping from watchdog being sent when connections is not established (cluster handshake not completed) as this could lead to ping requests without to or from attributes.

wojciech.kapcia@tigase.net commented 3 years ago

TC complained https://tc.tigase.net/viewLog.html?tab=buildChangesDiv&buildId=92509&buildTypeId=TigaseServer_Build even though it works for me locally...

Andrzej Wójcik (Tigase) commented 3 years ago

I do not know why tests passed on local devices as they should fail as ping was not sent due to missing to/from attributes. I've fixed that in the test case.

Type	Bug
Priority	Normal
Assignee	wojciech.kapcia@tigase.net
Version	Candidate for next minor release
Spent time	15m

Issue Votes (0)

Watchers (0)

Reference

tigase/_server/server-core#1244