Projects tigase _server server-core Issues #1240
NPE in StreamManagementIOProcessor (#1240)
Closed
wojciech.kapcia@tigase.net opened 3 years ago
java.lang.NullPointerException
	at tigase.server.xmppclient.StreamManagementIOProcessor$OutQueue.append(StreamManagementIOProcessor.java:650)
	at tigase.server.xmppclient.StreamManagementIOProcessor.processOutgoing(StreamManagementIOProcessor.java:252)
	at tigase.xmpp.XMPPIOService.addPacketToSend(XMPPIOService.java:128)
	at tigase.server.ConnectionManager.writePacketToSocket(ConnectionManager.java:593)
	at tigase.server.ConnectionManager.writePacketToSocket(ConnectionManager.java:862)
	at tigase.server.xmppclient.ClientConnectionManager.processPacket(ClientConnectionManager.java:131)
	at tigase.server.AbstractMessageReceiver$QueueListener.run(AbstractMessageReceiver.java:1397)
wojciech.kapcia@tigase.net commented 3 years ago
[2021-03-22 10:13:22:178] [SEVERE  ] [              in_7-c2s ] AbstractMessageReceiver$QueueListener.run(): [in_7-c2s] Exception during packet processing: from=sess-man@ip-172-31-19-108.us-west-2.compute.internal, to=c2s@ip-172-31-19-108.us-west-2.compute.internal/172.29.0.2_5222_172.31.19.125_45050, DATA=<presence xml:lang="en" to="andrzej.wojcik@tigase.org/1833767281-tigase-296" xmlns="jabber:client" from="xsf@muc.xmpp.org/mimi89999"><c hash="sha-1" ver="AhE2lHombaVuLH+aGV2OP7ARqCY=" xmlns="http://jabber.org/protocol/caps" node="http://conversations.im"/><x xmlns="vcard-temp:x:update"><photo>22aa40b3050c4d295597d8fdedffc5f2e504de11</photo></x><x xmlns="http://jabber.org/protocol/muc#user"><item role="participant" affiliation="none"/></x></presence>, SIZE=453, XMLNS=jabber:client, PRIORITY=PRESENCE, PERMISSION=ADMIN, TYPE=null, STABLE_ID=null
java.lang.NullPointerException
	at tigase.server.xmppclient.StreamManagementIOProcessor$OutQueue.append(StreamManagementIOProcessor.java:650)
	at tigase.server.xmppclient.StreamManagementIOProcessor.processOutgoing(StreamManagementIOProcessor.java:252)
	at tigase.xmpp.XMPPIOService.addPacketToSend(XMPPIOService.java:128)
	at tigase.server.ConnectionManager.writePacketToSocket(ConnectionManager.java:593)
	at tigase.server.ConnectionManager.writePacketToSocket(ConnectionManager.java:862)
	at tigase.server.xmppclient.ClientConnectionManager.processPacket(ClientConnectionManager.java:131)
	at tigase.server.AbstractMessageReceiver$QueueListener.run(AbstractMessageReceiver.java:1397)
wojciech.kapcia@tigase.net commented 3 years ago

Made a simple fix for NPE.

Most likely concurrency issue when in the first check the queue is not empty but before examining first element it gets flushed.

issue 1 of 1
Type
Bug
Priority
Normal
Assignee
Version
tigase-server-8.2.0
Issue Votes (0)
Watchers (0)
Reference
tigase/_server/server-core#1240
Please wait...
Page is in error, reload to recover