Andrzej Wójcik (Tigase) opened 4 years ago
|
|
|
|
@wojtek The same error is in 8.1.0 so it may be good to consider backporting this fix for a next bugfix release. |
|
As per off-YT conversation: please add relevant test cases for the issue and fix (so someone wouldn't apply other "fix" that would actually break something) |
|
According to the test case that you provided we could simplify
But it seems you were not OK with it. The idea of having a unit test was to avoid erroneous "improvement". Please provide proper test that indicates what current solution is the only proper one (and above yields incorrect result) Btw. I think |
|
I've added more tests to check chars with different code ranges from UTF8 specification and confirmed that your code works (in some cases even better). So I've replaced implementation and made a few changes, adjustments and comments, so I suppose that it is complete now. |
Type |
Bug
|
Priority |
Normal
|
Assignee | |
Version |
tigase-server-8.2.0
|
Spent time |
5h 30m
|
-
tigase/_server/tigase-push#31 You are not authorized to access this issue
-
tigase-private/systems-maintenance/servers#319 You are not authorized to access this issue
Infinite loop while cutting body of encrypted push notification to fit the push notifications limit