Multi-thread script execution yields wrong results (#1154)

Wojciech Kapcia (Tigase) opened 5 years ago

Affected versions
tigase-issue #7.1.0 tigase-issue #8.0.0 tigase-issue #8.1.0

It was reported that in concurrent execution ad-hoc script returns wrong results.

Wojciech Kapcia (Tigase) commented 5 years ago

Issue was caused by using global context in script execution, even though we used separate bindings.

@kobit considering that ad-hoc scripts are quite extensively by some used and form a base for HTTP-REST API, and due to this bug yield incorrect result under load, should we backport it to 8.0.0 (and maybe even 7.1.x, though with the release of 8.1.0 it will become obsolete/legacy)?
Artur Hefczyc commented 5 years ago

How much work is needed to backport the fix to older versions?
Wojciech Kapcia (Tigase) commented 5 years ago

Well, this is basically a one line change (see https://github.com/tigase/tigase-server/commit/1f26835584f6aadd38773163474778f362ca7a7f#diff-8d994b9bd297512765f1ee80f0480358L113) so a couple of minutes I guess. Not sure if cherry-pick would work directly.
Artur Hefczyc commented 5 years ago

Ok, please go ahead then for ver 8.x and 7.x
Wojciech Kapcia (Tigase) commented 5 years ago

Backported
Login to comment

Issue Votes (0)

Watchers (0)

Reference

tigase/_server/server-core#1154