Projects tigase _server server-core Issues #1135
Blocked contact not really blocked (#1135)
Closed
Artur Hefczyc opened 4 years ago

Maybe this is actually not Beagle but the server issue. I have just noticed a new chat on my list, from a spammer. As you can see on the screenshot the chat has the red icon on it, meaning the contact is blocked. But if it is blocked how did I receive it? I even remember blocking this specific spammer a few days ago.

Artur Hefczyc commented 4 years ago

I still keep the chat and not removing it in case you need any additional information or checking.

Artur Hefczyc commented 4 years ago

Ok, I did some more checking and there is no bug. The contact is blocked on kobit@tigase.org account but the new message came to artur.hefczyc@tigase.org account...

CleanShot 2020-04-01 at 15.43.57@2x.png

Artur Hefczyc commented 4 years ago

Actually, no. The message came to the kobit@tigase.org account. So there is a problem somewhere.

CleanShot 2020-04-01 at 15.46.41@2x.png

Andrzej Wójcik (Tigase) commented 4 years ago

From what I can see in logs, this is not a second message, but a message "resent" by StreamManagement when a connection to one of your clients (WebSocket connected one) was broken. They were connected to different cluster nodes, so the privacy list was out of sync (I do not see a code to sync it within a cluster).

As a result, when you blocked spammer in Beagle, it got blocked on node-1, but node-2 was not aware of that. When WebSocket based client (Parrot?) was disconnected it had unacked messages which were resent. Those messages were redelivered to newly connected Parrot and somehow caused redelivery to Beagle (skipped privacy check - maybe carbons caused that?). It would also explain why Beagle ignored "delay" timestamp as it does that in messages sent with carbons - as normally carbons are never delayed.

Andrzej Wójcik (Tigase) commented 4 years ago

As it was server related I've changed the project. The fix will be part of the next upgrade of tigase.org installation.

Artur Hefczyc commented 4 years ago

I know it is not yet deployed but I am closing it as fixed as for now it does not happens for me. Will reopen if the problem comes back.

issue 1 of 1
Type
Bug
Priority
Normal
Assignee
Spent time
4h 30m
Issue Votes (0)
Watchers (0)
Reference
tigase/_server/server-core#1135
Please wait...
Page is in error, reload to recover