Exceptions in s2s (#109)

Artur Hefczyc opened 1 decade ago

Due Date
2016-04-29

Please investigate severity of this exception. They happen on tigase.im installation.

2012-04-27 17:36:15  ConnectionManager.serviceStopped()  WARNING:  [[s2s]] Attempt to stop incorrect service: CID: null, null, type: accept, Socket: nullSocket[unconnected]
java.lang.Exception: Stack trace
        at java.lang.Thread.dumpStack(Thread.java:1249)
        at tigase.server.ConnectionManager.serviceStopped(ConnectionManager.java:493)
        at tigase.server.xmppserver.S2SConnectionManager.serviceStopped(S2SConnectionManager.java:696)
        at tigase.server.xmppserver.S2SConnectionManager.serviceStopped(S2SConnectionManager.java:70)
        at tigase.net.IOService.forceStop(IOService.java:297)
        at tigase.net.IOService.stop(IOService.java:614)
        at tigase.xmpp.XMPPIOService.stop(XMPPIOService.java:248)
        at tigase.server.xmppserver.proc.S2SAbstractProcessor.generateStreamError(S2SAbstractProcessor.java:107)
        at tigase.server.xmppserver.proc.StreamOpen.streamOpened(StreamOpen.java:267)
        at tigase.server.xmppserver.S2SConnectionManager.xmppStreamOpened(S2SConnectionManager.java:813)
        at tigase.server.xmppserver.S2SConnectionManager.xmppStreamOpened(S2SConnectionManager.java:70)
        at tigase.xmpp.XMPPIOService.xmppStreamOpened(XMPPIOService.java:454)
        at tigase.xmpp.XMPPDomBuilderHandler.startElement(XMPPDomBuilderHandler.java:302)
        at tigase.xml.SimpleParser.parse(SimpleParser.java:291)
        at tigase.xmpp.XMPPIOService.processSocketData(XMPPIOService.java:357)
        at tigase.net.IOService.call(IOService.java:235)
        at tigase.net.IOService.call(IOService.java:87)
        at java.util.concurrent.FutureTask$Sync.innerRun(FutureTask.java:303)
        at java.util.concurrent.FutureTask.run(FutureTask.java:138)
        at java.util.concurrent.Executors$RunnableAdapter.call(Executors.java:441)
        at java.util.concurrent.FutureTask$Sync.innerRun(FutureTask.java:303)
        at java.util.concurrent.FutureTask.run(FutureTask.java:138)
        at java.util.concurrent.ThreadPoolExecutor$Worker.runTask(ThreadPoolExecutor.java:886)
        at java.util.concurrent.ThreadPoolExecutor$Worker.run(ThreadPoolExecutor.java:908)
        at java.lang.Thread.run(Thread.java:662)
2012-04-27 17:37:11  ConnectionManager.serviceStopped()  WARNING:  [[s2s]] Attempt to stop incorrect service: CID: null, null, type: accept, Socket: nullSocket[unconnected]
java.lang.Exception: Stack trace
        at java.lang.Thread.dumpStack(Thread.java:1249)
        at tigase.server.ConnectionManager.serviceStopped(ConnectionManager.java:493)
        at tigase.server.xmppserver.S2SConnectionManager.serviceStopped(S2SConnectionManager.java:696)
        at tigase.server.xmppserver.S2SConnectionManager.serviceStopped(S2SConnectionManager.java:70)
        at tigase.net.IOService.forceStop(IOService.java:297)
        at tigase.net.SocketThread.addAllWaiting(SocketThread.java:456)
        at tigase.net.SocketThread.run(SocketThread.java:338)
        at java.lang.Thread.run(Thread.java:662)

Duplicate
- Exceptions in s2s implementation. (#140) Closed

Activities

Andrzej Wójcik (Tigase) commented 1 decade ago
This exception is thrown due to exception in accept method of IOService. I suppose it may be related to this:

2012-04-27 10:51:13 StreamOpen.serviceStopped() WARNING: Protocol error cid_conns not found for outgoing connection: CID: xn--m8js9b0b.xn--48jucxw.xn--r8jau4b8b4fa8gr9cba.net@gmail.com, null, type: accept, Socket: nullSocket[unconnected]

In accept method of IOService variable socketIO is used but it can be not initialized properly due to exception. This variable is used to get SocketChannel instance which we already have. (Passed to method as parameter)
Artur Hefczyc commented 1 decade ago

Si suppose this is very low severity and can be worked on at later time.
Andrzej Wójcik (Tigase) commented 9 years ago

I checked this code and this entry was logged using Thread.dumpStack() and in fact it was not an exception but verbose logging. As I checked this line was removed in #767 a while ago.

First comment in this task is still correct as it was result of error during accepting of connection. However it is properly handled and logging was changed from Warning to Finest so I'm closing this task.
Login to comment

Type	Bug
Priority	Minor
Assignee	Artur Hefczyc
RedmineID	541
Version	tigase-server-8.0.0
Estimation	0
Spent time	0

Issue Votes (0)

Watchers (0)

Reference

tigase/_server/server-core#109