Projects tigase _server server-core Issues #106
XMPPResourceConnection passed to filter method of XMPPPacketFilterIfc can contain wrong instance. (#106)
Closed
Andrzej Wójcik (Tigase) opened 1 decade ago

XMPPResourceConnection passed to filter method of XMPPPacketFilterIfc can contain wrong instance.

XMPPResourceConnection is correct for Packet passed as packet variable, but is not correct for packets in results queue. Packets in results queue may contains other destinations. This will happen if packets processed by session manager are addressed to bare jid and after processing send to clients (Presence from remote address with bare jid as destination).

Artur Hefczyc commented 1 decade ago

Has this been resolved yet?

Andrzej Wójcik (Tigase) commented 1 decade ago

I suppose it is not resolved as I do not recall any fix for this. MobileV2 plugin contains workaround for this issue at line 161.

Artur Hefczyc commented 1 decade ago

I think this is not a bug but that's how it is supposed to work. Please note, the packet passed as a parameter is the one which triggered processing. Packets passed in results queue are a result of the processing. Now, there might be many packets in results queue and each of them might be for a different destination, in case there are multiple connections for the user.

I am not sure if MobileV2 plugin takes into account that there might be presence packets in the results queue sent to different user's connections, some of them might not have the Mobile mode activated.

issue 1 of 1
Type
Bug
Priority
Normal
Assignee
RedmineID
518
Version
tigase-server-5.1.0
Issue Votes (0)
Watchers (0)
Reference
tigase/_server/server-core#106
Please wait...
Page is in error, reload to recover