Projects tigase _server server-core Issues #1038
Maven Surefire Plugin error (#1038)
Andrzej Wójcik (Tigase) opened 5 years ago

Maven Surefire plugin responsible for running tests fails all the time.

Andrzej Wójcik (Tigase) commented 5 years ago

I've mangaged to deal with XML formatting issues by changing maven-surefire-plugin version.

Andrzej Wójcik (Tigase) commented 5 years ago

@wojtek Please check if those changes shouldn't be moved to the ​parent project.

wojciech.kapcia@tigase.net commented 5 years ago

Andrzej, change looks ok and I moved it to projects-parent. A couple of comments:

  • we should stick to maintaining version information in projects-parent (therefore I removed it completely from tigase-server) - it helps maintaining projects configuration
  • bumping pluing version should not warrant bumping version of projects-parent: to that end I decided not to use -SNAPSHOT for project parent because it defied helpfulness of having parent with common configuration - we have version 1.0.2, updating surefire plugin version without bumping version fixes the issue with garbled test ouput in all projects inheriting from this version; i.e. you have to fix it in single repository instead of dozens or more
Andrzej Wójcik (Tigase) commented 5 years ago

@wojtek I agree with all the things which you mentioned about changes in a single repository. I've made my changes in tigase-server repository (not in the ​parent) just for a quick check and passed them to you for a review. If I would be sure that they should land directly in the parent, I would have put them there.

issue 1 of 1
Type
Bug
Priority
Normal
Assignee
Spent time
3h 30m
Issue Votes (0)
Watchers (0)
Reference
tigase/_server/server-core#1038
Please wait...
Page is in error, reload to recover