Cannot authenticate with non-english username (#1031)

Andrzej Wójcik (Tigase) opened 6 years ago

Affected versions
tigase-issue #8.0.0

It is possible to register a user with non-english characters in the username but authentication with SCRAM-* fails.

Created from message#8401

Andrzej Wójcik (Tigase) commented 6 years ago

I've applied a fix for this issue which solved it. I wonder whether we should backport it version 8.0.x?
Wojciech Kapcia (Tigase) commented 6 years ago

@andrzej.wojcik do we have test-case for it?
Andrzej Wójcik (Tigase) commented 6 years ago

Wojtek, I've not added a test case because the issue was an invalid regex, but if you want we could create TTS-NG test for it to check if everything works ok. As I mentioned, it was a simple change, so I've just fixed it and verified manually using XMPP client.
Wojciech Kapcia (Tigase) commented 6 years ago

@andrzej.wojcik Wouldn't it be enough to ad another teest to tigase.auth.mechanisms.SaslSCRAMTest?

I asked about test more for having it for regression-testing purposes.
Andrzej Wójcik (Tigase) commented 6 years ago

In theory, it should be possible.
Wojciech Kapcia (Tigase) commented 6 years ago

In that case please add relevant test-case.
Login to comment

Issue Votes (0)

Watchers (0)

Reference

tigase/_server/server-core#1031