-
I've fixed the license headers in "dist" project but looking at number of issues related to "headers" reported on the forum and as issues, it looks like this enforcement may be doing some harm, ie. users trying to build Tigase on their own (probably with some additional classes added by them without those headers) are failing during build time. While I agree that they most likely should create separate jars instead of modifying Tigase directly, this header checked increased fail ratio which make people think that usage of Tigase is "hard".
-
Andrzej Wójcik wrote:
I've fixed the license headers in "dist" project but looking at number of issues related to "headers" reported on the forum
I see only one issue ;-)
and as issues, it looks like this enforcement may be doing some harm, ie. users trying to build Tigase on their own (probably with some additional classes added by them without those headers) are failing during build time. While I agree that they most likely should create separate jars instead of modifying Tigase directly, this header checked increased fail ratio which make people think that usage of Tigase is "hard".
I agree - I'll reconfigure the projects so it won't do the check on every build and I'll call the check only in jenkins so if anything is missing job will fail.
Type |
Bug
|
Priority |
Normal
|
Assignee | |
RedmineID |
8656
|
Version |
tigase-server-8.0.0
|
Spent time |
0
|
tigase-server-distribution - Build # 1894 - Failure:
Check console output at http://build.tigase.net/jenkins/job/tigase-server-distribution/1894/ to view the results.
Changes: [Wojciech Kapcia] #8639 slightly adjust project name
Started by: Started by upstream project "multijob" build number 2,098