Make send methods non-throwable (#98)
Andrzej Wójcik (Tigase) opened 3 months ago

Send methods are using methods fun PacketWriter::write(request: Request<*,*>) or fun PacketWriter::writeDirectly(stanza: Element). Both of those methods are throwing exceptions when executed while connector is not connected or is not initialized.

Instead it would be expected that those methods would call callbacks/handlers with "remote server timeout" error informing callers that there was no response (it couldn't be as connection was not ready).

This is mainly due to many calls of methods that eventually send stanza that expect results (success or failure) and would need at the same time to handle thrown exception.

Andrzej Wójcik (Tigase) added "Related" tygrys/tygrys#227 3 months ago
Andrzej Wójcik (Tigase) changed state to 'In Progress' 3 months ago
Previous Value Current Value
Open
In Progress
Referenced from commit 3 months ago
Andrzej Wójcik (Tigase) changed state to 'In QA' 3 months ago
Previous Value Current Value
In Progress
In QA
Andrzej Wójcik (Tigase) commented 3 months ago

This change was made and after initial testing it works as expected.

issue 1 of 1
Type
Task
Priority
Normal
Assignee
Version
none
Sprints
n/a
Customer
n/a
Issue Votes (0)
Watchers (3)
Reference
tigase/_libraries/halcyon#98
Please wait...
Page is in error, reload to recover