![]() |
Bartosz Małkowski opened 4 years ago
|
![]() |
Module |
|
Please provide code examples for the following:
@andrzej.wojcik if I block a JID, on one resource will I get a notification about this new blocked JID on other connected resources? |
|
Sorry, added previous comment to a wrong ticket. Copied it to issue #42 ticket. For this one, I have question though. Do we have Spam reporting implemented yet? |
|
@andrzej.wojcik I am not sure what was the last conclusion from our discussion about spam reporting/user blocking. From what I remember we decided to have Spam Reporting only and user blocking would be implemented on the server side as part of the server side implementation for handling spam? |
|
Yes, but we have decided to use XEP-0377 for spam reporting and that is based on using Yes, this is what we wanted and good thing is that we are reusing blocking command mechanism. |
|
Ah, in such a case, this is even better. @bmalkow does the library API support both options? I mean can I choose with the API whether to simply block the user or report a spam? Please provide code examples. |
![]() |
It is hard to invent code example:
You can also may listen for information about updates of blocked list:
But those events will be fired only when client previously retrieve list of blocked contacts (in other case, server do not push information):
|
|
It's not hard. The above examples is exactly what we need. You can incorporate them into the Halcyon documentation. |
|
@andrzej.wojcik just to confirm. We are implementing here XEP-0377, not the XEP-0191, right? I can see 2 possible reasons for blocking:
|
|
@kobit We have support for XEP-0377 and XEP-0191 (XEP-0377 is addition to (extension for) XEP-0191).
XEP-0377 specifies 2 reasons for "blocking" and reporting user as a spammer or abuser. However, there is still a possibility to use just XEP-0191 by just omitting Currently, when any reason is specified (spam or abuse) then server blocks user by adding it to PrivacyList (just as Blocking Command does - that is shared code) and then notifies
In this case just use reason
Use reason |
|
Thanks, now everything is clear. I will close the ticket once I get it all working in Convene. |
|
Sevan will be taking over client implementation, so we need to have it documented in one place. @bmalkow please add this to our documentation for the Kangaroo project in the Kangaroo github repo. |
|
I meant, of course above description with code examples. |
![]() |
Documentation to module is here: https://github.com/tigase/halcyon/blob/master/src/docs/asciidoc/text/modules/BlockingCommandModule.asciidoc Should I also add it to Kangaroo GitHub repo? If yes, then where exactly? |
|
I am assigning this to Sevan who now works on the client code. @sevan.evans this might be overwhelming for you right now but you will understand this once you get deeper into the code. In any case, please do not hesitate to ask questions either to me or to Bartek. |
![]() |
Spam reporting added to client. When blocking a user, the client will be prompted with whether they would like to report the offender for spam. If yes is clicked, the JID will be reported with the |
Type |
New Feature
|
Priority |
Normal
|
Assignee | |
Spent time |
2h
|
Add support for XEP-0377