DefaultTickTimer fires multiple events after application suspension (#103)

Activities

Andrzej Wójcik (Tigase) opened 2 months ago

DefaultTickTimer fires multiple events after application suspension

Referenced from commit 2 months ago

Fixed DefaultTickTimer firing multiple events after application suspension #103

Andrzej Wójcik (Tigase) committed 2 months ago

5fb35ea8

Andrzej Wójcik (Tigase) changed state to 'In Progress' 2 months ago

Previous Value	Current Value
Open	In Progress

Andrzej Wójcik (Tigase) added "Related" tygrys/tygrys#205 2 months ago

Andrzej Wójcik (Tigase) changed state to 'In QA' 2 months ago

Previous Value	Current Value
In Progress	In QA

Andrzej Wójcik (Tigase) commented 2 months ago

It looks like this simple change resolves the issue.

Andrzej Wójcik (Tigase) changed fields 2 months ago

Name	Previous Value	Current Value
Assignee	andrzej.wojcik	wojtek

Artur Hefczyc commented 2 months ago

Is this change already committed? I am asking because this ticket was updated 12h ago and the last successful build for the Tygrys app is from 15h ago. And Android build is not yet working.

Andrzej Wójcik (Tigase) commented 2 months ago

Change is committed and the next build will include those changes. Issues with Android app building were caused by a different change and were just fixed (build is now in progress).

Referenced from commit 1 month ago

Properly stop ticker event when connection is stopped; #103

wojciech.kapcia@tigase.net committed 1 month ago

8ac2fbf4

wojciech.kapcia@tigase.net commented 1 month ago

After yesterday fix it seems that situation finally improved and the ticker sticks to 2s intervals and there is only single instance:

10:35:54.915 System.out           I  Verbose: (DefaultTickTimer) Firing timer, this/run: tigase.halcyon.core.xmpp.modules.tick.DefaultTickTimer$startTimer$1@a8869e8, task: tigase.halcyon.core.xmpp.modules.tick.DefaultTickTimer$startTimer$1@a8869e8, timer: java.util.Timer@dc9f801
10:35:54.922 ConnectionService    I  Event: TickEvent(counter=12881) for account: AbstractHalcyon(boundJID=w@chat4.im/1436386422-tigase-16, state=Connected, running=true)
10:35:56.918 System.out           I  Verbose: (DefaultTickTimer) Firing timer, this/run: tigase.halcyon.core.xmpp.modules.tick.DefaultTickTimer$startTimer$1@a8869e8, task: tigase.halcyon.core.xmpp.modules.tick.DefaultTickTimer$startTimer$1@a8869e8, timer: java.util.Timer@dc9f801
10:35:56.922 ConnectionService    I  Event: TickEvent(counter=12882) for account: AbstractHalcyon(boundJID=w@chat4.im/1436386422-tigase-16, state=Connected, running=true)
10:35:58.918 System.out           I  Verbose: (DefaultTickTimer) Firing timer, this/run: tigase.halcyon.core.xmpp.modules.tick.DefaultTickTimer$startTimer$1@a8869e8, task: tigase.halcyon.core.xmpp.modules.tick.DefaultTickTimer$startTimer$1@a8869e8, timer: java.util.Timer@dc9f801
10:35:58.919 ConnectionService    I  Event: TickEvent(counter=12883) for account: AbstractHalcyon(boundJID=w@chat4.im/1436386422-tigase-16, state=Connected, running=true)
10:36:00.917 System.out           I  Verbose: (DefaultTickTimer) Firing timer, this/run: tigase.halcyon.core.xmpp.modules.tick.DefaultTickTimer$startTimer$1@a8869e8, task: tigase.halcyon.core.xmpp.modules.tick.DefaultTickTimer$startTimer$1@a8869e8, timer: java.util.Timer@dc9f801
10:36:00.919 ConnectionService    I  Event: TickEvent(counter=12884) for account: AbstractHalcyon(boundJID=w@chat4.im/1436386422-tigase-16, state=Connected, running=true)

And the account connected just fine in the morning after sleeping the computer for the night (which wasn't the case previously)

Type	Bug
Priority	Normal
Assignee	wojciech.kapcia@tigase.net
Version	none
Sprints	n/a
Customer	n/a

Issue Votes (0)

Watchers (3)

Reference

tigase/_libraries/halcyon#103