Tigase Forge
Dashboards
Projects
Pull Requests
Issues
Builds
Packages
Code Search
Martin
Code
Pull Requests
Issues
List
Boards
Iterations
Builds
Statistics
Child Projects
OneDev 11.5.2
Documentation Support & Bug Report RESTful API Incompatibilities License Agreement Check Update
Projects tigase _libraries Martin Issues #70
Document behaviour of Element class equality check method (#70)
Andrzej Wójcik (Tigase) opened 4 years ago

As mentioned in https://github.com/tigase/tigase-swift/pull/7 Element class does only a shallow equality check but it is undocumented behaviour and not a bug.
Andrzej Wójcik (Tigase) commented 4 years ago

Added documentation for behaviour of this method and rejected pull request.
Andrzej Wójcik (Tigase) commented 4 years ago

I've reviewed my statement on equality check. I've removed implementation of Equatable protocol from Node class and all its subclasses. Moved from equality checks in element child removal code to reference comparisons and update documentation about that. I've also added detailed equality check method and added unit tests for that.
issue 1 of 1
Type
Task
Priority
Normal
Assignee
Andrzej Wójcik (Tigase)
Issue Votes (0)
Login to vote
Watchers (0)
Reference
tigase/_libraries/Martin#70
Please wait...
Page is in error, reload to recover