Bookmarks not received in some cases (#59)
Andrzej Wójcik (Tigase) opened 5 years ago

In some cases, PubSub notifications are not delivered from PEP nodes upon connection end sending CAPS.

Andrzej Wójcik (Tigase) commented 5 years ago

It looks like the issue is actually with ejabberd PubSub/PEP implementation which just decided no to send last published item when it receives storage:bookmarks+notify with a set of features supported by the client. This is against the PEP specification which states:

When a PEP service receives initial presence [13] from a subscriber's resource including XEP-0115 information that indicates an interest in the data format, it MUST generate a notification containing at least the last published item for that node and send it to the newly-available resource; see below under Sending the Last Published Item.

I'm adding a workaround for the in the client library when I will be aware that we have connected to buggy ejabberd server.

wojciech.kapcia@tigase.net commented 5 years ago

@andrzej.wojcik - have you reported this to ejabberd? Maybe cooperating with them and including proper fix in their implementation would be a good idea (and Holger seems to be quite cooperative)

Andrzej Wójcik (Tigase) commented 5 years ago

I thought about it but in the end, I've ended up with a workaround as roll-out of a fix will take some time either way.

wojciech.kapcia@tigase.net commented 5 years ago

Yes, it will take time but I think that having fixed something instead of adding workarounds for bugs is better. I'll take care of that.

issue 1 of 1
Type
Bug
Priority
Normal
Assignee
Issue Votes (0)
Watchers (0)
Reference
tigase/_libraries/Martin#59
Please wait...
Page is in error, reload to recover