Add support for OMEMO (#265)
Closed
Andrzej Wójcik (Tigase) opened 5 years ago

Add support for OMEMO https://conversations.im/omemo/

Andrzej Wójcik (Tigase) commented 5 years ago

%bmalkow We assume that we are using the external library from Signal (libsignal) to be able to do so, we need to change the license of the project (and license of Jaxmpp) to GPLv3.

Please assign this task for the next big version after VoIP is released.

Bartosz Małkowski commented 5 years ago

OMEMO in Stork works more or less. For sure not all possible features are implemented. I think we should create separated tasks for bugs and new required features.

Bartosz Małkowski commented 5 years ago

@wojtek would you like to test it?

wojciech.kapcia@tigase.net commented 5 years ago

@bmalkow any chances for APK? :-)

Bartosz Małkowski commented 5 years ago
wojciech.kapcia@tigase.net commented 5 years ago

I tried to test it and.. wasn't able to get encrypted messages between any of the apps (Stork vs BeagleIM, Psi+, Conversations and Monal):

  • most of the time either Stork or other application weren't able to actually detect signing keys thus no encryption (BeagleIM offered option to sent unencrypted message in that case)

  • quite often I got "Can't decprypt message: message is not encrypted for this device"

  • the fingerprint I see in Stork in account preferences isn't the same to fingerprint conversations displays in contact details (I would assume that in order to have working encryption between the two those should be the same - correct?)

  • when trying to enable encryption in Stork (click on the lock) I always get screen with OMEMO header and blank whitespace (fills the screen)

  • it would be nice to have management of my own devices

  • it would be nice to see fingerprints of the contact

wojciech.kapcia@tigase.net commented 5 years ago

@bmalkow

Where there any changes made? I don't see any commits in repository (https://github.com/tigase/stork/commits/master) but I do see time entries. If there is a new code could you please share APK file?

wojciech.kapcia@tigase.net commented 5 years ago

New version: https://www.dropbox.com/sh/blur61z7qsw251c/AACG6MijTpQ-DW-Nt2HylHb0a?dl=0

Comments from the test:

  • works between two accounts on tigase.org installation (mine and Bartek's) with Beagle and Stork
  • messages sent from tigase.im (stork)-> tigase.org (beagle) works but in opposite direction (same pair of accounts) I get "message is not encrypted for this device"
    • After couple of more tests it stopped working as well; tigase.im fingerprint shown in stork (20a7…516d) is not displayed in BeagleIM's list of contact devices.
  • between sure.im (beagle) and tigase.im (stork) it didn't work in neither direction

It worked between sure.im (conv) and tigase.org (beagle).

It does seem to work between accounts on tigase.org (beagle-stork, stork-conversation) so it seems that the problem may still be with tigase.installation -- @andrzej.wojcik - have you run into any more problems with that installation? You cleared it yesterday, fixed permission (sql update for all accounts?) and restarted it today - correct?

Andrzej Wójcik (Tigase) commented 5 years ago

@wojtek Yes, I've fixed issues with affiliations of PEP nodes on tigase.im/sure.im installation and restarted nodes to reload those changes from the database. Except from that, I've not seen any issues.

As PEP uses PubSub and its cache maybe we should check if nodes for OMEMO are published correctly and automatically delivered to the recipients?

Referenced from commit 11 months ago
Referenced from commit 11 months ago
Referenced from commit 11 months ago
issue 1 of 1
Type
New Feature
Priority
Blocker
Assignee
RedmineID
8838
Spent time
151h 39m
Issue Votes (0)
Watchers (0)
Reference
tigase/_clients/stork#265
Please wait...
Page is in error, reload to recover