Siskin crash on contacts search (#591)

Artur Hefczyc opened 1 year ago

I go to Contacts list, click on the Search icon and enter x (trying to search for xmpp contacts) and the app instantly crashes. Tries different letters, a does not crash instantly but as soon as I enter second a it does crash.

I am not sure if this is specific to my list of contacts, as mentioned before, I have a lot of spammer contacts now in my roster, some with weird names, maybe they cause the problem.

Related
- Update WebRTC library (#593) In QA

Activities

Andrzej Wójcik (Tigase) commented 1 year ago

In my case it works as expected. I suppose it may be related to weird names. Anyway, lets keep issue open. I'll try to look into crash logs tomorrow.
Andrzej Wójcik (Tigase) commented 1 year ago

Did you have this issue on iPad? Was displaying groups in roster enabled?

If so, you could try to disable display roster groups to check if that helps and maybe temporary mitigate the issue.
Artur Hefczyc commented 1 year ago

Yes, this is on iPad and yes, groups are enabled, and yes - disabling groups works as a workaround.
Andrzej Wójcik (Tigase) added "Related" #593 1 year ago
Andrzej Wójcik (Tigase) commented 1 year ago

During testing of this issue, I've found an issue with running Siskin IM in iOS simulator that stopped me from testing possible fix in Siskin IM. When issue #593 is resolve, I can follow with testing fixes for this issue.
Andrzej Wójcik (Tigase) commented 1 year ago

@kobit I think I've found the source of the issue. I've applied the fix and I'm testing locally a fix for this issue. I think I will try to push a build using TestFlight tomorrow with a fix for this issue as version 7.4.0-b1
Artur Hefczyc commented 1 year ago

Great, thank you.
Andrzej Wójcik (Tigase) commented 1 year ago

New version was uploaded to TestFlight.
Andrzej Wójcik (Tigase) changed state to 'In Progress' 1 year ago
Previous Value Current Value
Open

In Progress
Andrzej Wójcik (Tigase) changed state to 'In QA' 1 year ago
Previous Value Current Value
In Progress

In QA
Artur Hefczyc changed state to 'Closed' 1 year ago
Previous Value Current Value
In QA

Closed
Artur Hefczyc commented 1 year ago

No crash in the testflight version 7.4.0
Login to comment

Previous Value	Current Value
Open	In Progress

Previous Value	Current Value
In Progress	In QA

Previous Value	Current Value
In QA	Closed

Type	Bug
Priority	Normal
Assignee	Andrzej Wójcik (Tigase)
Version	7.3.3
Sprints	n/a
Customer	n/a

Issue Votes (0)

Watchers (3)

Reference

tigase/_clients/siskin-im#591