Tigase Forge
Dashboards
Projects
Pull Requests
Issues
Builds
Packages
Code Search
siskin-im
Code
Pull Requests
Issues
List
Boards
Iterations
Builds
Statistics
Child Projects
OneDev 11.6.0
Documentation Support & Bug Report RESTful API Incompatibilities License Agreement Check Update
Projects tigase _clients siskin-im Issues #537
Sends wrong 'creator' and 'senders' in Jingle session-accept (#537)
Unknown opened 3 years ago

When Siskin receives a Jingle session-initiate like

<iq id='15279acd-9b25-4be9-809d-10fa928c9021' type='set' to='bla@example.com/iPad'>
  <jingle xmlns='urn:xmpp:jingle:1' action='session-initiate' initiator='user@example.com/resource' sid='abc'>
    <content creator='initiator' name='audio' senders='both'>
      <description xmlns='urn:xmpp:jingle:apps:rtp:1' media='audio'>... </description>
      <transport xmlns='urn:xmpp:jingle:transports:ice-udp:1' ufrag='k1xC' pwd='YQQOiZyUfT+0/Jdtjx30JB'>...</transport>
    </content>
  </jingle>
</iq>

It responds with

<iq type='set' id='8DB441AE-FF07-476D-A6A3-B56675E5BCAD' from='bla@example.com/iPad' to='user@example.com/resource' lang='en'>
  <jingle action='session-accept' xmlns='urn:xmpp:jingle:1' responder='bla@example.com/iPad' sid='abc'>
    <content senders='initiator' name='audio' creator='responder'>
      <description media='audio' xmlns='urn:xmpp:jingle:apps:rtp:1'>...</description>
      <transport pwd='KgU6AmdNYlVY93pDwkAfwy9o' xmlns='urn:xmpp:jingle:transports:ice-udp:1' ufrag='86Ib'>...</transport>
    </content>
  </jingle>
</iq>
  • The creator of the content in the session-initiate was set to initiator, since the content was added by the initiator of the session. However, Siskin wrongly replaces the creator with responder.
  • senders is set to both in the session-initiate, but Siskin sets it to initiator. I doubt that Siskin actually intends to only have audio working one way. But even if this was on purpose, it's not allowed to just change the senders without sending a modify-senders Jingle message first.

Siskin version: 7.0.1
Unknown commented 3 years ago

@fiaxh Could you state which server (software and versions) were you using during the test? Was Push used to initiate this call? Were permissions to access microphone/camera already granted to SiskinIM?
Unknown commented 3 years ago

Weird thing is that during my testing (today) senders was set to both which as you mentioned it should be.
issue 1 of 1
Type
Bug
Issue Votes (0)
Login to vote
Watchers (0)
Reference
tigase/_clients/siskin-im#537
Please wait...
Page is in error, reload to recover