the oob image preview not working with omemo (#385)

Unknown opened 6 years ago

Describe the bug Client message encryption set to None If the client sends an image with http upload to someone the preview is shown correctly.

Client message encryption set to Omemo If the client sends an image with http upload to someone the preview is not shown.

To Reproduce Steps to reproduce the behavior:

Expected behavior The preview should be shown either way.

Screenshots Screenshot_20190927-205736_Conversations

Smartphone (please complete the following information):

Unknown commented 6 years ago

This "issue" is caused by the fact that OMEMO is not encrypting links sent as OOB only message body. Due to the fact that SiskinIM does not support AESGCM at this point for encryption of transferred files, we decide to allow file transfer but not to send OOB but just a link in the message body. This decision was because of security reasons and will not be changed until we ship support for AESGCM.

The alternative solution would be for Conversations to check if the message body is a link and show a preview if it is a link to the image.
Unknown commented 5 years ago

Now SiskinIM supports encrypted file transfer for OMEMO encrypted chats and file previews should be presented correctly without OOB.
Login to comment

Issue Votes (0)

Watchers (0)

Reference

tigase/_clients/siskin-im#385