resource is (practically) hardcoded to 'iPhone' instead of device name (#216)
Unknown opened 1 year ago

Describe the bug

Siskin uses the device name in order to set the resource string ( But in iOS 16, has changed to only return the generic model of the device (e.g. 'iPhone'), not the user specified name. Hence in iOS 16 Siskin exclusively sets 'iPhone' as resource string, which is not unique per device and is also rather unhelpful when debugging the same username logged in into several devices.

Proposed solution should be used, instead of, cf.

Alternative solution proposal Let the server generate the resource, cf.,_let_the_server_generate_a_resource_for_you

To Reproduce Steps to reproduce the behavior:

  1. Go to device settings and set a device name different than 'iPhone'
  2. Use Siskin
  3. See that Siskin only sets 'iPhone' as client resource

Expected behavior Siskin uses the device name as base for the resource so that different devices also get different resources.

cf. RFC 7622

Typically, a resourcepart uniquely identifies a specific connection

Details (please complete the following information):

  • Siskin Version: 7.3.3
  • iOS version: 16.4.1
  • iPhone model: iPhone XR
Unknown commented 1 year ago

In the future version, we will drop usage of device name at all as the resource. As new version will support SASL2 and Bind2 we will use similar way to generate resource for SASL1 and Bind1 (random opaque string).

issue 1 of 1
Issue Votes (0)
Watchers (0)
Please wait...
Page is in error, reload to recover