file transfer button disabled for upload.pouet.ovh (#185)

Wojciech Kapcia (Tigase) opened 5 years ago

Report from muc:

[2020-02-03 11:26:08] <ludo> > is the client connected when trying to upload file?
I think so...!imagen.png!
[2020-02-03 15:05:37] <ludo> ij: oh yes I forgot to specify that I use an external module (https://github.com/weiss/ngx_http_upload) made by Holger, thanks by the way ??

Support seems to be correctly advertised (and works in Beagle: "[2020-02-03 15:52:50] Well in Beagle it worked with my account (same server) with previous version. Didn't try with the 3.5..."):

<iq to="upload.pouet.ovh" id="aad3a" type="get">
<query xmlns="http://jabber.org/protocol/disco#info"/>
</iq>

<iq xml:lang="en" to="wojtek@jabster.pl/Psi+" id="aad3a" from="upload.pouet.ovh" type="result">
<query xmlns="http://jabber.org/protocol/disco#info">
<identity category="store" name="HTTP File Upload" type="file"/>
<feature var="urn:xmpp:http:upload"/>
<feature var="urn:xmpp:http:upload:0"/>
<feature var="eu:siacs:conversations:http:upload"/>
<feature var="vcard-temp"/>
<feature var="http://jabber.org/protocol/disco#info"/>
<feature var="http://jabber.org/protocol/disco#items"/>
<x xmlns="jabber:x:data" type="result">
<field type="hidden" var="FORM_TYPE">
<value>urn:xmpp:http:upload</value>
</field>
<field label="Maximum file size" type="text-single" var="max-file-size">
<value>209715200</value>
</field>
</x>
<x xmlns="jabber:x:data" type="result">
<field type="hidden" var="FORM_TYPE">
<value>urn:xmpp:http:upload:0</value>
</field>
<field label="Maximum file size" type="text-single" var="max-file-size">
<value>209715200</value>
</field>
</x>
<x xmlns="jabber:x:data" type="result">
<field type="hidden" var="FORM_TYPE">
<value>http://jabber.org/network/serverinfo</value>
</field>
<field type="list-multi" var="abuse-addresses">
<value>mailto:abuse@nuage.me</value>
</field>
<field type="list-multi" var="support-addresses">
<value>https://xmpp.nuage.me</value>
<value>mailto:support@nuage.me</value>
<value>xmpp:support@conference.nuage.me?join</value>
</field>
<field type="list-multi" var="admin-addresses">
<value>mailto:xmpp@nuage.me</value>
<value>xmpp:admin@nuage.me</value>
</field>
</x>
</query>
</iq>

imagen.png

Activities

Andrzej Wójcik (Tigase) commented 5 years ago

Was HTTP File upload enabled in SiskinIM settings?
Wojciech Kapcia (Tigase) commented 5 years ago

It seems it was not:

[2020-02-06 14:56:22] Wojtek: yes !! Thanks for the hint, I didn't know this option...

I think we should either enable it by default or prompt user to enable it... or maybe - add action to attach icon: if the user click on it and server doesn't support then show notification and if server does support it enable it? (not sure if we need the option anyway)
Andrzej Wójcik (Tigase) commented 5 years ago

The option is there to make sure that the user is aware that the file is uploaded to HTTP server and readable by everyone. We could just make a check if HTTP upload is "enabled" in option then don't ask, in other case keep button active but ask for user consent and enable option.
Wojciech Kapcia (Tigase) commented 5 years ago

+1 to consent
Andrzej Wójcik (Tigase) commented 5 years ago

The behavior is changed, so now the button is active and if HTTP upload was not enabled, user will be asked.
Login to comment

Type	Bug
Priority	Normal
Assignee	Wojciech Kapcia (Tigase)

Issue Votes (0)

Watchers (0)

Reference

tigase/_clients/siskin-im#185