Random "User session terminated" messages (#53)

Unknown opened 4 years ago

Describe the bug Every once in a while, I will see "User session terminated" inserted into a DM conversation. In this latest instance, they were inserted after the last few messages (that varied from 1-3 minutes old)

To Reproduce Not sure

Expected behavior Some sort of indication of what is going on (does it meant that the server died or the other party's client died? Were the messages actually transmitted? I guess at least some were because I got replies to them.)

Screenshots session-term

Desktop (please complete the following information):

OS: MacOS
Browser N/A
Version 10.14.6

Additional context Add any other context about the problem here.

Unknown commented 4 years ago

You receive those errors (those are message of type error) sent back to you by the remote server (recipients XMPP server).

This is not a bug. This is normal response of a client upon receiving a message of type error. If those messages would be lost, you would want to be notified, right?

The bug is on the remote server as it should not sent those messages of type error if those message were delivered to the end user's device or stored in the offline storage.

Unknown commented 4 years ago

What's confusing is that they seem to be inserted into already seen portions of the conversation (I mean, if the other party hadn't seen them, he wouldn't have replied what he did). Is there some sort of persistent context for a message that allows a later status update?

I realized that I'm not being clear on what I experienced. I had been having the above conversation and then after a moment, those User session terminated messages appeared after the fact, in the middle of the conversation.

Unknown commented 4 years ago

Messages (also those with type error) may contain timestamp details when they should be placed in a history XEP-0203: Delayed Delivery and if that would be there, then Beagle will use that information to place the message in the history.

However, I suppose, that error is sent to you not when message with "text" is not delivered but when you receive a message with a response, then Beagle sends confirmation that it received that messages. I suppose that when this message is received by the remote server, the recipient is gone (disconnected) and remote server sends an error back.

Unknown commented 4 years ago

I'm not sure how much context is available when those errors come from the far end -- but if there is enough to say "failed to get acknowledgement of confirmation" (or whatever is going on) that would be somewhat more helpful in allowing a user to diagnose what is going on.

Unknown commented 4 years ago

/backlink issue #535

Unknown commented 4 years ago

Agreed that this message a bit terrible. I have received more that 10 same messages in a one minute. Version 4.1

Referenced from commit 7 days ago

Do not display errors for message delivery confirmations not being delivered #53

Andrzej Wójcik (Tigase) committed 4 years ago

12349277

	Unknown opened 4 years ago Describe the bug Every once in a while, I will see "User session terminated" inserted into a DM conversation. In this latest instance, they were inserted after the last few messages (that varied from 1-3 minutes old) To Reproduce Not sure Expected behavior Some sort of indication of what is going on (does it meant that the server died or the other party's client died? Were the messages actually transmitted? I guess at least some were because I got replies to them.) Screenshots Desktop (please complete the following information): OS: MacOS Browser N/A Version 10.14.6 Additional context Add any other context about the problem here.
	Unknown commented 4 years ago You receive those errors (those are message of type `error`) sent back to you by the remote server (recipients XMPP server). This is not a bug. This is normal response of a client upon receiving a message of type `error`. If those messages would be lost, you would want to be notified, right? The bug is on the remote server as it should not sent those messages of type `error` if those message were delivered to the end user's device or stored in the offline storage.
	Unknown commented 4 years ago What's confusing is that they seem to be inserted into already seen portions of the conversation (I mean, if the other party hadn't seen them, he wouldn't have replied what he did). Is there some sort of persistent context for a message that allows a later status update? I realized that I'm not being clear on what I experienced. I had been having the above conversation and then after a moment, those `User session terminated` messages appeared after the fact, in the middle of the conversation.
	Unknown commented 4 years ago Messages (also those with type `error`) may contain timestamp details when they should be placed in a history XEP-0203: Delayed Delivery and if that would be there, then Beagle will use that information to place the message in the history. However, I suppose, that error is sent to you not when message with "text" is not delivered but when you receive a message with a response, then Beagle sends confirmation that it received that messages. I suppose that when this message is received by the remote server, the recipient is gone (disconnected) and remote server sends an error back.
	Unknown commented 4 years ago I'm not sure how much context is available when those errors come from the far end -- but if there is enough to say "failed to get acknowledgement of confirmation" (or whatever is going on) that would be somewhat more helpful in allowing a user to diagnose what is going on.
	Unknown commented 4 years ago /backlink issue #535
	Unknown commented 4 years ago Agreed that this message a bit terrible. I have received more that 10 same messages in a one minute. Version 4.1
	Referenced from commit 7 days ago Do not display errors for message delivery confirmations not being delivered #53 Andrzej Wójcik (Tigase) committed 4 years ago 12349277