Show account in presence subscription request (#486)
wojciech.kapcia@tigase.net opened 2 years ago

When we receive presence request we don't know to which account it was sent. It would be good to include information which account received the request.

Andrzej Wójcik (Tigase) commented 2 years ago
wojciech.kapcia@tigase.net commented 2 years ago

I'm on 5.3.4 (176) and just got a bunch of spam (both presence and messages) and I'm fairly certain I didn't see account name in the presence sub form.

I just checked and I think there is a bug:

  1. add user wojtek@sure.im to account wojtek@xmpp.cloud

  2. following presence sub is received:

<!--   2023-04-19T19:19:16Z   <<<<   -->
<presence type='subscribe' to='wojtek@sure.im' xmlns='jabber:client' from='wojtek@xmpp.cloud'/>
  1. dialog shows the same JID as the account owner:

"Authorise wojtek@xmpp.cloud

Do you want to allow access to your online status and associated data for account wojtek@xmpp.cloud?"

Btw. I think we could improve wording/presentation (JIDs in bold, requesting JID repeated, added "for"):

"Do you want to allow wojtek@xmpp.cloud to access to your online status and associated data for your account wojtek@xmpp.cloud?"

Andrzej Wójcik (Tigase) commented 2 years ago

Fix released in the new beta build 5.3.5-b177

issue 1 of 1
Type
Task
Priority
Normal
Assignee
Issue Votes (0)
Watchers (0)
Reference
tigase/_clients/beagle-im#486
Please wait...
Page is in error, reload to recover