External users should be able to edit and delete their own PR comments (SZ-101)
rk@tigase.net opened 1 week ago

Caveat identified during SZ-77 implementation.

Currently updateComment and deleteComment in PullRequestController blanket-block external users via requireInternal(). An external user should be permitted to edit or delete their own comments. Proposed fix: Add getComment(commentId) to PullRequestService, then replace the blanket requireInternal() in both methods with an author-or-internal check — same pattern as updateCommentVisibility in IssueController. Risk until fixed: External users cannot edit or delete their own PR comments. Conservative, not a security gap. Estimate: 1.5 hours.

issue 1 of 1
Type
Bug
Priority
Normal
Assignee
Version
1.9.2
Sprints
n/a
Customer
n/a
Issue Votes (0)
Watchers (3)
Reference
SZ-101
Please wait...
Page is in error, reload to recover